From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752166AbdFNJMM (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Jun 2017 05:12:12 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:33532 "EHLO
        mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751459AbdFNJMJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Jun 2017 05:12:09 -0400
Date: Wed, 14 Jun 2017 17:12:06 +0800
From: Wei Yang <richard.weiyang@gmail.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Wei Yang <richard.weiyang@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux-MM <linux-mm@kvack.org>, Mel Gorman <mgorman@suse.de>,
        Vlastimil Babka <vbabka@suse.cz>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Jerome Glisse <jglisse@redhat.com>,
        Reza Arbab <arbab@linux.vnet.ibm.com>,
        Yasuaki Ishimatsu <yasu.isimatu@gmail.com>, qiuxishi@huawei.com,
        Kani Toshimitsu <toshi.kani@hpe.com>, slaoub@gmail.com,
        Joonsoo Kim <js1304@gmail.com>, Andi Kleen <ak@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Daniel Kiper <daniel.kiper@oracle.com>,
        Igor Mammedov <imammedo@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 04/14] mm, memory_hotplug: get rid of
 is_zone_device_section
Message-ID: <20170614091206.GA15768@WeideMacBook-Pro.local>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20170515085827.16474-1-mhocko@kernel.org>
 <20170515085827.16474-5-mhocko@kernel.org>
 <CADZGycawwb8FBqj=4g3NThvT-uKREbaH+kYAxvXRrW1Vd5wsvA@mail.gmail.com>
 <20170614061259.GB14009@WeideMBP.lan>
 <20170614063206.GF6045@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="VbJkn9YxBvnuCH5J"
Content-Disposition: inline
In-Reply-To: <20170614063206.GF6045@dhcp22.suse.cz>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--VbJkn9YxBvnuCH5J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 14, 2017 at 08:32:06AM +0200, Michal Hocko wrote:
>On Wed 14-06-17 14:12:59, Wei Yang wrote:
>[...]
>> Hi, Michal
>>=20
>> Not sure you missed this one or you think this is fine.
>>=20
>> Hmm... this will not happen since we must offline a whole memory_block?
>
>yes
>
>> So the memory_hotplug/unplug unit is memory_block instead of mem_section?
>
>yes.

If this is true, the check_hotplug_memory_range() should be fixed too.

This function just makes sure the range is section aligned, instead of
memory_block aligned.

>--=20
>Michal Hocko
>SUSE Labs

--=20
Wei Yang
Help you, Help me

--VbJkn9YxBvnuCH5J
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZQP3mAAoJEKcLNpZP5cTd6mcP/joHK9/njSIGJRCRitDOU9xX
aKGv8lEfZmG74NinxghfW8gxTwajggfcUAy9Z/dqp3xSdV4wZgozESiDB9WCSj5m
ZWDqtCIJab+v7GdkOMylznP8eoRbBZC/fdUse4IVybQN6KUZDN5ZUWqOLxs9krup
g2vVry4PpzJ9sFegYrBfnh8tUSu2ixSLFrqe0Kg76Oz88hgSjcgRNoWtGiZmLqaX
A6UEuMi18Ec19Xj5f8/LJLUU+bdYoiMY+x+5OFq47PUdT3K8gdzLh6aHCCWENR4N
B6FysQngjOX6k0Trzf1GZZ06ICWqjfk6fFv4F5dSrq87pzX/DGQ4lMB2jNCMo36q
NcmPaelHLmBJcUIlKf6uetVRnSmsKeYDGZwK2owHQ+Fe0KNKz9WlgoY6iBgUgV3J
ewo829HLXVfBEXI0svcAo1TQaoEeMVGLRpBAg6HrHOxGLfBDfTMw4MfPGgIKhoZA
1v2PpO6umgZNlUKGnK7uTbuXlrsgILYrwyzLN0tz8l1kEuR0r7u40JcWml3l6enC
gdrWf88hNAZeEYTygbp8OUJ+ciCQ86pi8VW9thGYE4HCSDhabzITx4fZbycCfn/f
2T2aylqaCPK8qKGhTBCign66+lfGuPpHUBNjOEAbVHOLBT3S1MJmTfxybUBhjq9L
hsp4h1l3ijuqTf1qO8IT
=Ohwl
-----END PGP SIGNATURE-----

--VbJkn9YxBvnuCH5J--