From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226AbdFPRRp (ORCPT ); Fri, 16 Jun 2017 13:17:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51916 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbdFPRRo (ORCPT ); Fri, 16 Jun 2017 13:17:44 -0400 Date: Fri, 16 Jun 2017 10:17:43 -0700 From: Andrew Morton To: Kees Cook Cc: Stephen Rothwell , Linux-Next Mailing List , Linux Kernel Mailing List , Daniel Micay Subject: Re: linux-next: build failure after merge of the akpm-current tree Message-Id: <20170616101743.f2e5c255612b2e3e7ee596e2@linux-foundation.org> In-Reply-To: References: <20170605170117.6a1fc15e@canb.auug.org.au> <20170615113548.3e4edcf4@canb.auug.org.au> <20170615121220.4331a37b0fb736ec9da4e423@linux-foundation.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jun 2017 16:46:33 -0700 Kees Cook wrote: > On Thu, Jun 15, 2017 at 12:12 PM, Andrew Morton > wrote: > > On Wed, 14 Jun 2017 18:56:30 -0700 Kees Cook wrote: > > > >> >> Caused by commit > >> >> > >> >> 088a5ecf7581 ("include/linux/string.h: add the option of fortified string.h functions") > >> >> > >> >> We really need to fix all the known problems it detects *before* > >> >> merging this commit ... > >> >> > >> >> I have reverted it for today. > >> > > >> > I am still needing to revert this every day ... > >> > >> I sent a series for -mm (or maintainers) to merge that should catch > >> everything. Do you want me to carry it in my kspp tree instead? (My > >> original intention was to carry all the fixes and the fortify patch in > >> kspp but akpm took it into -mm somewhat unexpectedly, not that I'm > >> complaining.) > > > > This is all getting a bit foggy in my mind. Can we please have a full > > resend of everything? Sufficient to hopefully produce a tree which has > > no build-time or run-time regressions? Including the buildbot's > > recently-reported alpha and xtensa issues? > > It's been sent a few times (and a few fixes have been collected in > other trees already). What I've got in my for-next/kspp tree right now > is all the fixes that haven't already been picked up by other tree > maintainers, and I added the fortify patch itself to the end of the > tree too now since sfr asked for that a few hours ago. I think it's best to try to keep everything in a single tree, with maintainer acks where possible. I do this stuff all the time - please just send everything at me when we think we have all the fixes and I'll sort it out.