From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753834AbdFPNhM (ORCPT ); Fri, 16 Jun 2017 09:37:12 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:55377 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753781AbdFPNhK (ORCPT ); Fri, 16 Jun 2017 09:37:10 -0400 Date: Fri, 16 Jun 2017 15:36:44 +0200 From: Simon Horman To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Wolfram Sang , Rob Herring , devicetree@vger.kernel.org, Russell King , linux-renesas-soc@vger.kernel.org, Rob Herring , Magnus Damm , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [RESEND PATCH v5 06/16] ARM: dts: r7s72100: Add generic compatible string for I2C EEPROM Message-ID: <20170616133644.GA26834@verge.net.au> References: <20170615185418.13980-1-javier@dowhile0.org> <20170615185418.13980-7-javier@dowhile0.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170615185418.13980-7-javier@dowhile0.org> Organisation: Horms Solutions BV User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2017 at 08:54:08PM +0200, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Geert Uytterhoeven Thanks, I have queued this up in the renesas tree for v4.14. From mboxrd@z Thu Jan 1 00:00:00 1970 From: horms@verge.net.au (Simon Horman) Date: Fri, 16 Jun 2017 15:36:44 +0200 Subject: [RESEND PATCH v5 06/16] ARM: dts: r7s72100: Add generic compatible string for I2C EEPROM In-Reply-To: <20170615185418.13980-7-javier@dowhile0.org> References: <20170615185418.13980-1-javier@dowhile0.org> <20170615185418.13980-7-javier@dowhile0.org> Message-ID: <20170616133644.GA26834@verge.net.au> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jun 15, 2017 at 08:54:08PM +0200, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Geert Uytterhoeven Thanks, I have queued this up in the renesas tree for v4.14.