From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753812AbdFSIub (ORCPT ); Mon, 19 Jun 2017 04:50:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:47533 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753767AbdFSIu3 (ORCPT ); Mon, 19 Jun 2017 04:50:29 -0400 Date: Mon, 19 Jun 2017 10:50:26 +0200 From: Jan Kara To: Tahsin Erdogan Cc: Jan Kara , Jan Kara , "Theodore Ts'o" , Andreas Dilger , Dave Kleikamp , Alexander Viro , Mark Fasheh , Joel Becker , Jens Axboe , Deepa Dinamani , Mike Christie , Fabian Frederick , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org Subject: Re: [PATCH 23/28] mbcache: make mbcache more generic Message-ID: <20170619085026.GD11837@quack2.suse.cz> References: <20170531081517.11438-1-tahsin@google.com> <20170531081517.11438-23-tahsin@google.com> <20170615074158.GA1764@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 15-06-17 11:25:02, Tahsin Erdogan wrote: > On Thu, Jun 15, 2017 at 12:41 AM, Jan Kara wrote: > > Can you explain a bit more what do you mean by "make it more generic" as it > > seems you just rename a couple of things here... > > The change is really just that, having names that are more generic > which do not limit use cases to block sharing. In a subsequent patch > in the series ("[PATCH v4 27/28] ext4: xattr inode deduplication"), we > start using the mbcache code to share xattr inodes. With that patch, > old mb_cache_entry.e_block field could be holding either a block > number or an inode number, so I renamed things to make them more > generic. OK, then I'd suggest to change title to "mbcache: make mbcache naming more generic" and explain what you wrote here in the changelog. Thanks! Honza -- Jan Kara SUSE Labs, CR From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kara Date: Mon, 19 Jun 2017 10:50:26 +0200 Subject: [Ocfs2-devel] [PATCH 23/28] mbcache: make mbcache more generic In-Reply-To: References: <20170531081517.11438-1-tahsin@google.com> <20170531081517.11438-23-tahsin@google.com> <20170615074158.GA1764@quack2.suse.cz> Message-ID: <20170619085026.GD11837@quack2.suse.cz> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tahsin Erdogan Cc: Jan Kara , Jan Kara , Theodore Ts'o , Andreas Dilger , Dave Kleikamp , Alexander Viro , Mark Fasheh , Joel Becker , Jens Axboe , Deepa Dinamani , Mike Christie , Fabian Frederick , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org On Thu 15-06-17 11:25:02, Tahsin Erdogan wrote: > On Thu, Jun 15, 2017 at 12:41 AM, Jan Kara wrote: > > Can you explain a bit more what do you mean by "make it more generic" as it > > seems you just rename a couple of things here... > > The change is really just that, having names that are more generic > which do not limit use cases to block sharing. In a subsequent patch > in the series ("[PATCH v4 27/28] ext4: xattr inode deduplication"), we > start using the mbcache code to share xattr inodes. With that patch, > old mb_cache_entry.e_block field could be holding either a block > number or an inode number, so I renamed things to make them more > generic. OK, then I'd suggest to change title to "mbcache: make mbcache naming more generic" and explain what you wrote here in the changelog. Thanks! Honza -- Jan Kara SUSE Labs, CR