From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbdFTCon (ORCPT ); Mon, 19 Jun 2017 22:44:43 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36133 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbdFTCol (ORCPT ); Mon, 19 Jun 2017 22:44:41 -0400 Date: Mon, 19 Jun 2017 19:44:37 -0700 From: Dmitry Torokhov To: Robert Jarzmik Cc: Lee Jones , Jaroslav Kysela , Takashi Iwai , Daniel Mack , Haojian Zhuang , Liam Girdwood , Mark Brown , Lars-Peter Clausen , Charles Keepax , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 06/12] Input: wm97xx: add new AC97 bus support Message-ID: <20170620024437.GB21379@dtor-ws> References: <1497857229-12049-1-git-send-email-robert.jarzmik@free.fr> <1497857229-12049-7-git-send-email-robert.jarzmik@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1497857229-12049-7-git-send-email-robert.jarzmik@free.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2017 at 09:27:03AM +0200, Robert Jarzmik wrote: > This adds support for the new AC97 bus code, which discovers the devices > rather than uses platform data. > > As part of this discovery, it enables a multi-function device wm97xx, > which supports touchscreen, battery, ADC and an audio codec. This patch > adds the code to bind the touchscreen "cell" as the touchscreen driver. > > This was tested on the pxa architecture with a pxa270 + wm9713 + the > mioa701 touchscreen. > > Signed-off-by: Robert Jarzmik > Acked-by: Charles Keepax Acked-by: Dmitry Torokhov > --- > drivers/input/touchscreen/Kconfig | 2 +- > drivers/input/touchscreen/wm97xx-core.c | 56 ++++++++++++++++++++++++++++++++- > 2 files changed, 56 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig > index 033599777651..22257f3e1059 100644 > --- a/drivers/input/touchscreen/Kconfig > +++ b/drivers/input/touchscreen/Kconfig > @@ -725,7 +725,7 @@ config TOUCHSCREEN_WM831X > > config TOUCHSCREEN_WM97XX > tristate "Support for WM97xx AC97 touchscreen controllers" > - depends on AC97_BUS > + depends on AC97_BUS || AC97_BUS_NEW > help > Say Y here if you have a Wolfson Microelectronics WM97xx > touchscreen connected to your system. Note that this option > diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c > index 39869ffdc4fa..fd714ee881f7 100644 > --- a/drivers/input/touchscreen/wm97xx-core.c > +++ b/drivers/input/touchscreen/wm97xx-core.c > @@ -44,6 +44,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -766,6 +767,39 @@ static int wm97xx_remove(struct device *dev) > return 0; > } > > +static int wm97xx_mfd_probe(struct platform_device *pdev) > +{ > + struct wm97xx *wm; > + struct wm97xx_platform_data *mfd_pdata = dev_get_platdata(&pdev->dev); > + int ret; > + > + wm = devm_kzalloc(&pdev->dev, sizeof(struct wm97xx), GFP_KERNEL); > + if (!wm) > + return -ENOMEM; > + > + wm->dev = &pdev->dev; > + wm->ac97 = mfd_pdata->ac97; > + > + ret = _wm97xx_probe(wm); > + if (ret) > + return ret; > + > + ret = wm97xx_add_battery(wm, mfd_pdata->batt_pdata); > + if (ret < 0) > + goto batt_err; > + > + return ret; > + > +batt_err: > + wm97xx_unregister_touch(wm); > + return ret; > +} > + > +static int wm97xx_mfd_remove(struct platform_device *pdev) > +{ > + return wm97xx_remove(&pdev->dev); > +} > + > static int __maybe_unused wm97xx_suspend(struct device *dev) > { > struct wm97xx *wm = dev_get_drvdata(dev); > @@ -862,21 +896,41 @@ EXPORT_SYMBOL_GPL(wm97xx_unregister_mach_ops); > > static struct device_driver wm97xx_driver = { > .name = "wm97xx-ts", > +#ifdef CONFIG_AC97_BUS > .bus = &ac97_bus_type, > +#endif > .owner = THIS_MODULE, > .probe = wm97xx_probe, > .remove = wm97xx_remove, > .pm = &wm97xx_pm_ops, > }; > > +static struct platform_driver wm97xx_mfd_driver = { > + .driver = { > + .name = "wm97xx-ts", > + .pm = &wm97xx_pm_ops, > + }, > + .probe = wm97xx_mfd_probe, > + .remove = wm97xx_mfd_remove, > +}; > + > static int __init wm97xx_init(void) > { > - return driver_register(&wm97xx_driver); > + int ret; > + > + ret = platform_driver_register(&wm97xx_mfd_driver); > + if (ret) > + return ret; > + > + if (IS_BUILTIN(CONFIG_AC97_BUS)) > + ret = driver_register(&wm97xx_driver); > + return ret; > } > > static void __exit wm97xx_exit(void) > { > driver_unregister(&wm97xx_driver); > + platform_driver_unregister(&wm97xx_mfd_driver); > } > > module_init(wm97xx_init); > -- > 2.1.4 > -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 06/12] Input: wm97xx: add new AC97 bus support Date: Mon, 19 Jun 2017 19:44:37 -0700 Message-ID: <20170620024437.GB21379@dtor-ws> References: <1497857229-12049-1-git-send-email-robert.jarzmik@free.fr> <1497857229-12049-7-git-send-email-robert.jarzmik@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1497857229-12049-7-git-send-email-robert.jarzmik@free.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Robert Jarzmik Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen , linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com, Liam Girdwood , Haojian Zhuang , Takashi Iwai , Mark Brown , linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, Charles Keepax , Lee Jones , Daniel Mack List-Id: linux-input@vger.kernel.org On Mon, Jun 19, 2017 at 09:27:03AM +0200, Robert Jarzmik wrote: > This adds support for the new AC97 bus code, which discovers the devices > rather than uses platform data. > > As part of this discovery, it enables a multi-function device wm97xx, > which supports touchscreen, battery, ADC and an audio codec. This patch > adds the code to bind the touchscreen "cell" as the touchscreen driver. > > This was tested on the pxa architecture with a pxa270 + wm9713 + the > mioa701 touchscreen. > > Signed-off-by: Robert Jarzmik > Acked-by: Charles Keepax Acked-by: Dmitry Torokhov > --- > drivers/input/touchscreen/Kconfig | 2 +- > drivers/input/touchscreen/wm97xx-core.c | 56 ++++++++++++++++++++++++++++++++- > 2 files changed, 56 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig > index 033599777651..22257f3e1059 100644 > --- a/drivers/input/touchscreen/Kconfig > +++ b/drivers/input/touchscreen/Kconfig > @@ -725,7 +725,7 @@ config TOUCHSCREEN_WM831X > > config TOUCHSCREEN_WM97XX > tristate "Support for WM97xx AC97 touchscreen controllers" > - depends on AC97_BUS > + depends on AC97_BUS || AC97_BUS_NEW > help > Say Y here if you have a Wolfson Microelectronics WM97xx > touchscreen connected to your system. Note that this option > diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c > index 39869ffdc4fa..fd714ee881f7 100644 > --- a/drivers/input/touchscreen/wm97xx-core.c > +++ b/drivers/input/touchscreen/wm97xx-core.c > @@ -44,6 +44,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -766,6 +767,39 @@ static int wm97xx_remove(struct device *dev) > return 0; > } > > +static int wm97xx_mfd_probe(struct platform_device *pdev) > +{ > + struct wm97xx *wm; > + struct wm97xx_platform_data *mfd_pdata = dev_get_platdata(&pdev->dev); > + int ret; > + > + wm = devm_kzalloc(&pdev->dev, sizeof(struct wm97xx), GFP_KERNEL); > + if (!wm) > + return -ENOMEM; > + > + wm->dev = &pdev->dev; > + wm->ac97 = mfd_pdata->ac97; > + > + ret = _wm97xx_probe(wm); > + if (ret) > + return ret; > + > + ret = wm97xx_add_battery(wm, mfd_pdata->batt_pdata); > + if (ret < 0) > + goto batt_err; > + > + return ret; > + > +batt_err: > + wm97xx_unregister_touch(wm); > + return ret; > +} > + > +static int wm97xx_mfd_remove(struct platform_device *pdev) > +{ > + return wm97xx_remove(&pdev->dev); > +} > + > static int __maybe_unused wm97xx_suspend(struct device *dev) > { > struct wm97xx *wm = dev_get_drvdata(dev); > @@ -862,21 +896,41 @@ EXPORT_SYMBOL_GPL(wm97xx_unregister_mach_ops); > > static struct device_driver wm97xx_driver = { > .name = "wm97xx-ts", > +#ifdef CONFIG_AC97_BUS > .bus = &ac97_bus_type, > +#endif > .owner = THIS_MODULE, > .probe = wm97xx_probe, > .remove = wm97xx_remove, > .pm = &wm97xx_pm_ops, > }; > > +static struct platform_driver wm97xx_mfd_driver = { > + .driver = { > + .name = "wm97xx-ts", > + .pm = &wm97xx_pm_ops, > + }, > + .probe = wm97xx_mfd_probe, > + .remove = wm97xx_mfd_remove, > +}; > + > static int __init wm97xx_init(void) > { > - return driver_register(&wm97xx_driver); > + int ret; > + > + ret = platform_driver_register(&wm97xx_mfd_driver); > + if (ret) > + return ret; > + > + if (IS_BUILTIN(CONFIG_AC97_BUS)) > + ret = driver_register(&wm97xx_driver); > + return ret; > } > > static void __exit wm97xx_exit(void) > { > driver_unregister(&wm97xx_driver); > + platform_driver_unregister(&wm97xx_mfd_driver); > } > > module_init(wm97xx_init); > -- > 2.1.4 > -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 From: dmitry.torokhov@gmail.com (Dmitry Torokhov) Date: Mon, 19 Jun 2017 19:44:37 -0700 Subject: [PATCH v2 06/12] Input: wm97xx: add new AC97 bus support In-Reply-To: <1497857229-12049-7-git-send-email-robert.jarzmik@free.fr> References: <1497857229-12049-1-git-send-email-robert.jarzmik@free.fr> <1497857229-12049-7-git-send-email-robert.jarzmik@free.fr> Message-ID: <20170620024437.GB21379@dtor-ws> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 19, 2017 at 09:27:03AM +0200, Robert Jarzmik wrote: > This adds support for the new AC97 bus code, which discovers the devices > rather than uses platform data. > > As part of this discovery, it enables a multi-function device wm97xx, > which supports touchscreen, battery, ADC and an audio codec. This patch > adds the code to bind the touchscreen "cell" as the touchscreen driver. > > This was tested on the pxa architecture with a pxa270 + wm9713 + the > mioa701 touchscreen. > > Signed-off-by: Robert Jarzmik > Acked-by: Charles Keepax Acked-by: Dmitry Torokhov > --- > drivers/input/touchscreen/Kconfig | 2 +- > drivers/input/touchscreen/wm97xx-core.c | 56 ++++++++++++++++++++++++++++++++- > 2 files changed, 56 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig > index 033599777651..22257f3e1059 100644 > --- a/drivers/input/touchscreen/Kconfig > +++ b/drivers/input/touchscreen/Kconfig > @@ -725,7 +725,7 @@ config TOUCHSCREEN_WM831X > > config TOUCHSCREEN_WM97XX > tristate "Support for WM97xx AC97 touchscreen controllers" > - depends on AC97_BUS > + depends on AC97_BUS || AC97_BUS_NEW > help > Say Y here if you have a Wolfson Microelectronics WM97xx > touchscreen connected to your system. Note that this option > diff --git a/drivers/input/touchscreen/wm97xx-core.c b/drivers/input/touchscreen/wm97xx-core.c > index 39869ffdc4fa..fd714ee881f7 100644 > --- a/drivers/input/touchscreen/wm97xx-core.c > +++ b/drivers/input/touchscreen/wm97xx-core.c > @@ -44,6 +44,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -766,6 +767,39 @@ static int wm97xx_remove(struct device *dev) > return 0; > } > > +static int wm97xx_mfd_probe(struct platform_device *pdev) > +{ > + struct wm97xx *wm; > + struct wm97xx_platform_data *mfd_pdata = dev_get_platdata(&pdev->dev); > + int ret; > + > + wm = devm_kzalloc(&pdev->dev, sizeof(struct wm97xx), GFP_KERNEL); > + if (!wm) > + return -ENOMEM; > + > + wm->dev = &pdev->dev; > + wm->ac97 = mfd_pdata->ac97; > + > + ret = _wm97xx_probe(wm); > + if (ret) > + return ret; > + > + ret = wm97xx_add_battery(wm, mfd_pdata->batt_pdata); > + if (ret < 0) > + goto batt_err; > + > + return ret; > + > +batt_err: > + wm97xx_unregister_touch(wm); > + return ret; > +} > + > +static int wm97xx_mfd_remove(struct platform_device *pdev) > +{ > + return wm97xx_remove(&pdev->dev); > +} > + > static int __maybe_unused wm97xx_suspend(struct device *dev) > { > struct wm97xx *wm = dev_get_drvdata(dev); > @@ -862,21 +896,41 @@ EXPORT_SYMBOL_GPL(wm97xx_unregister_mach_ops); > > static struct device_driver wm97xx_driver = { > .name = "wm97xx-ts", > +#ifdef CONFIG_AC97_BUS > .bus = &ac97_bus_type, > +#endif > .owner = THIS_MODULE, > .probe = wm97xx_probe, > .remove = wm97xx_remove, > .pm = &wm97xx_pm_ops, > }; > > +static struct platform_driver wm97xx_mfd_driver = { > + .driver = { > + .name = "wm97xx-ts", > + .pm = &wm97xx_pm_ops, > + }, > + .probe = wm97xx_mfd_probe, > + .remove = wm97xx_mfd_remove, > +}; > + > static int __init wm97xx_init(void) > { > - return driver_register(&wm97xx_driver); > + int ret; > + > + ret = platform_driver_register(&wm97xx_mfd_driver); > + if (ret) > + return ret; > + > + if (IS_BUILTIN(CONFIG_AC97_BUS)) > + ret = driver_register(&wm97xx_driver); > + return ret; > } > > static void __exit wm97xx_exit(void) > { > driver_unregister(&wm97xx_driver); > + platform_driver_unregister(&wm97xx_mfd_driver); > } > > module_init(wm97xx_init); > -- > 2.1.4 > -- Dmitry