From: Andrew Lunn <andrew@lunn.ch>
To: John Crispin <john@phrozen.org>
Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Sean Wang <sean.wang@mediatek.com>,
netdev@vger.kernel.org
Subject: Re: [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct
Date: Tue, 20 Jun 2017 15:54:39 +0200 [thread overview]
Message-ID: <20170620135439.GA12383@lunn.ch> (raw)
In-Reply-To: <20170620080655.7251-2-john@phrozen.org>
On Tue, Jun 20, 2017 at 10:06:55AM +0200, John Crispin wrote:
> The MT7530 inserts the 4 magic header in between the 802.3 address and
> protocol field. The patch defines these header such that the flow_disector
> can properly parse the packet and thus allows hashing to function properly.
This is to do with tagging, not the switch driver. The Marvell switch
driver can be used with two different tagging protocols.
So i would put these fields in the dsa_device_ops.
Andrew
next prev parent reply other threads:[~2017-06-20 13:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 8:06 [RFC 1/2] net-next: fix DSA flow_disection John Crispin
2017-06-20 8:06 ` [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct John Crispin
2017-06-20 13:54 ` Andrew Lunn [this message]
2017-06-20 17:27 ` John Crispin
2017-06-20 18:02 ` Andrew Lunn
2017-06-20 10:17 ` [RFC 1/2] net-next: fix DSA flow_disection Sergei Shtylyov
2017-06-20 14:01 ` Andrew Lunn
2017-06-20 17:30 ` Florian Fainelli
2017-06-20 17:38 ` John Crispin
2017-06-20 17:37 ` John Crispin
2017-06-20 21:52 ` Andrew Lunn
2017-06-21 4:33 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620135439.GA12383@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.