From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: pass machine size to sparse
Date: Tue, 20 Jun 2017 16:49:39 +0100 [thread overview]
Message-ID: <20170620154938.GH21131@arm.com> (raw)
In-Reply-To: <20170620122443.35880-1-luc.vanoostenryck@gmail.com>
On Tue, Jun 20, 2017 at 02:24:43PM +0200, Luc Van Oostenryck wrote:
> When using sparse on the arm64 tree we get many thousands of
> warnings like 'constant ... is so big it is unsigned long long'
> or 'shift too big (32) for type unsigned long'. This happens
> because by default sparse considers the machine as 32bit and
> defines the size of the types accordingly.
>
> Fix this by passing the '-m64' flag to sparse so that
> sparse can correctly define longs as being 64bit.
>
> CC: Catalin Marinas <catalin.marinas@arm.com>
> CC: Will Deacon <will.deacon@arm.com>
> CC: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> arch/arm64/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index f839ecd91..15d6c1476 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -62,7 +62,7 @@ LD += -EL
> UTS_MACHINE := aarch64
> endif
>
> -CHECKFLAGS += -D__aarch64__
> +CHECKFLAGS += -D__aarch64__ -m64
Looks fine to me, but just wondering whether or not we should also be
passing something to indicate the endianness of the target. Does sparse care
about that?
Will
next prev parent reply other threads:[~2017-06-20 15:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 12:24 [PATCH] arm64: pass machine size to sparse Luc Van Oostenryck
2017-06-20 15:49 ` Will Deacon [this message]
2017-06-20 16:24 ` Luc Van Oostenryck
2017-06-20 16:24 ` Luc Van Oostenryck
2017-06-20 17:04 ` Will Deacon
2017-06-20 17:04 ` Will Deacon
2017-06-20 19:07 ` Luc Van Oostenryck
2017-06-20 19:07 ` Luc Van Oostenryck
2017-06-21 16:12 ` Will Deacon
2017-06-21 16:12 ` Will Deacon
2017-06-21 16:54 ` Luc Van Oostenryck
2017-06-21 16:54 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170620154938.GH21131@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.