From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752440AbdFTUlV (ORCPT ); Tue, 20 Jun 2017 16:41:21 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:53019 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbdFTUlT (ORCPT ); Tue, 20 Jun 2017 16:41:19 -0400 From: Arnd Bergmann To: Andrew Lunn , Florian Fainelli Cc: Arnd Bergmann , "David S. Miller" , Timur Tabi , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: phy: smsc: fix buffer overflow in memcpy Date: Tue, 20 Jun 2017 22:40:46 +0200 Message-Id: <20170620204059.790066-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:oiaDB0rb2JP4oP4HvA1tIjMda/+8fTvmTmaLZUH6hNT+xkKsfxe ZOXC8td/f8ukl14MwLSAR/Pzx+M0MeyxtKEoERRZCtHaHn9014vbzXDsFquxhmF+bQP9KTU +KFmHXUwh0xCOLd7jDHqQ+THPBja5seeZW0FdZxyBaJFMM5rw7WHrBK5mjN2TpATMeFmFgf 7jZncWrvVRZEigYSqmYDg== X-UI-Out-Filterresults: notjunk:1;V01:K0:8b3iqOflEjo=:In4vejaCFQiP6kvnZsqeTJ VvPnoE8l+IXyjtx9X4nYdNTgxhH5s/9bOQQysAO8rt/JuruqfW4XPdaGKnBlru2N1K7NqYaC6 1ahE9LEOc8jJKyZywfUt4PXFBmaxDNnPZVTob5me2iw0YKGDN1SyBQsQ7lYn1fsjFVtYqmc/W PvOgBH9G+RkEho74ckLY1hIXANCXXSc+ySOQDDmeFMow8AIBLXlqfR7CfPPTOs9L9gAEe6SJu 4hBXdBSG/9QFR+WtLT8ySeVcJReJ3karRJd3YlcMQs0g0yZ3zmRixpQM1A7fwVJ3piX3OY0aK bR5nFn5dYHmDK3pmd6OIGcISxPm4aKqqhBrrC6Nk0zW/BvWwNOFntkiG3zDa0Et9/bV0sOr3H T/0JM7LtbsCfhgDza9odZRRFcxNdTslENNmuTj/5eaG/RDs1w6lMF3yqfSSBoZPl9m6GMn/Ij EaZjC98usclYGyugzQ7Eb8mPc1EwgBPbYT5GS5IzXbpdZyOOQpc52+6lhlBMGHsNr50Jb+VNR A9PSD29Mp3yG4F7CpTM605MpEN4JxRI1ssJON6ahB56W/1Nuy43hnjZu0ZadWaliXl/e2RUiB xR1RxDFx9xB2LNgrmwfDeCJS5KLAosAeI4TCqy0orxz7zlPKuCiCkEC2t8ZEzJahYunGifHKY RBSm4/tr8vyEbE4G06iQveaRZy0S/OK7prhuJEBYnO2zvKAibjT6cXgkRKje4/BqTZVQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The memcpy annotation triggers for a fixed-length buffer copy: In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0, from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21, from /git/arm-soc/include/linux/spinlock.h:87, from /git/arm-soc/include/linux/seqlock.h:35, from /git/arm-soc/include/linux/time.h:5, from /git/arm-soc/include/linux/stat.h:21, from /git/arm-soc/include/linux/module.h:10, from /git/arm-soc/drivers/net/phy/smsc.c:20: In function 'memcpy', inlined from 'smsc_get_strings' at /git/arm-soc/drivers/net/phy/smsc.c:166:3: /git/arm-soc/include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter Using strncpy instead of memcpy should do the right thing here. Fixes: 030a89028db0 ("net: phy: smsc: Implement PHY statistics") Signed-off-by: Arnd Bergmann --- drivers/net/phy/smsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c index 1b8204be064c..2306bfae057f 100644 --- a/drivers/net/phy/smsc.c +++ b/drivers/net/phy/smsc.c @@ -163,7 +163,7 @@ static void smsc_get_strings(struct phy_device *phydev, u8 *data) int i; for (i = 0; i < ARRAY_SIZE(smsc_hw_stats); i++) { - memcpy(data + i * ETH_GSTRING_LEN, + strncpy(data + i * ETH_GSTRING_LEN, smsc_hw_stats[i].string, ETH_GSTRING_LEN); } } -- 2.9.0