From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752605AbdFTV0O (ORCPT <rfc822;w@1wt.eu>);
        Tue, 20 Jun 2017 17:26:14 -0400
Received: from mga06.intel.com ([134.134.136.31]:3066 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752548AbdFTV0M (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Jun 2017 17:26:12 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.39,366,1493708400"; 
   d="scan'208";a="115504160"
Date: Tue, 20 Jun 2017 17:34:48 -0400
From: Keith Busch <keith.busch@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Marc Zyngier <marc.zyngier@arm.com>, Christoph Hellwig <hch@lst.de>,
        Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Michael Ellerman <mpe@ellerman.id.au>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [patch 32/55] x86/irq: Restructure fixup_irqs()
Message-ID: <20170620213447.GE24415@localhost.localdomain>
References: <20170619233700.547167146@linutronix.de>
 <20170619235445.774272454@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170619235445.774272454@linutronix.de>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 20, 2017 at 01:37:32AM +0200, Thomas Gleixner wrote:
> @@ -441,18 +440,27 @@ void fixup_irqs(void)
>  
>  	for_each_irq_desc(irq, desc) {
>  		const struct cpumask *affinity;
> -		int break_affinity = 0;
> -		int set_affinity = 1;
> +		bool break_affinity = false;
>  
>  		if (!desc)
>  			continue;
> -		if (irq == 2)
> -			continue;
>  
>  		/* interrupt's are disabled at this point */
>  		raw_spin_lock(&desc->lock);
>  
>  		data = irq_desc_get_irq_data(desc);
> +		chip = irq_data_get_irq_chip(data);
> +		/*
> +		 * The interrupt descriptor might have been cleaned up
> +		 * already, but it is not yet removed from the radix
> +		 * tree. If the chip does not have an affinity setter,
> +		 * nothing to do here.
> +		 */
> +		if (!chip !chip->irq_set_affinity) {
> +			raw_spin_unlock(&desc->lock);
> +			continue;
> +		}

A bit of a moot point since the very next patch deletes all of this,
but found this broken 'if' condition when compiling one at a time,
missing the '&&'.