From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [GIT PULL] Please pull my kvm-ppc-fixes branch Date: Wed, 21 Jun 2017 09:37:56 +1000 Message-ID: <20170620233756.GA3644@fergus.ozlabs.ibm.com> References: <20170620043035.avphtcoght2iiyug@oak.ozlabs.ibm.com> <20170620123907.GC10325@potion> <3bc0aeed-136b-5b7f-03a4-17b3aae31842@redhat.com> <20170620151700.GF10325@potion> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Paolo Bonzini , kvm@vger.kernel.org, David Gibson , kvm-ppc@vger.kernel.org To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from ozlabs.org ([103.22.144.67]:56483 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752585AbdFTXiB (ORCPT ); Tue, 20 Jun 2017 19:38:01 -0400 Content-Disposition: inline In-Reply-To: <20170620151700.GF10325@potion> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jun 20, 2017 at 05:17:01PM +0200, Radim Krčmář wrote: > 2017-06-20 14:55+0200, Paolo Bonzini: > > On 20/06/2017 14:39, Radim Krčmář wrote: > > > 2017-06-20 14:30+1000, Paul Mackerras: > > >> Paolo, > > >> > > >> Please do a pull from my kvm-ppc-fixes branch to get 6 commits that I > > >> would like to have go into 4.12, because they fix problems that could > > >> cause hangs or crashes in the host (the first and last commit, but > > >> only on POWER9 systems), or they fix problems that could allow guests > > >> to potentially affect or disrupt the execution of the controlling > > >> userspace (the other four). They are all marked to go to stable. > > > > > > Pulled, but only locally at the moment -- would you like me to apply > > > "[PATCH v2] KVM: MIPS: Fix maybe-uninitialized build failure" directly? > > > > Why not, isn't the tree yours? :) > > Right, and the arch doesn't even match ... let's forget I asked. :) > > Pushed into kvm/master, thanks. Thanks. On a related note, we still have the warning in virt/kvm/kvm_main.c for CONFIG_SMP=n builds about the variable 'wait' being unused in kvm_make_all_cpus_request(), because smp_call_function_many() doesn't reference its 'wait' argument for uniprocessor configs. This then causes the build to fail on powerpc because kvm_main.c actually gets compiled under arch/powerpc, and we use -Werror for arch/powerpc by default. Paolo posted a sketch of a patch to make smp_call_function_many be a static inline instead of a macro on UP, but it wasn't quite right and no-one sent it anywhere. Paolo, if you're OK with me cleaning it up and sending it on, I'll do that. Paul. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Tue, 20 Jun 2017 23:37:56 +0000 Subject: Re: [GIT PULL] Please pull my kvm-ppc-fixes branch Message-Id: <20170620233756.GA3644@fergus.ozlabs.ibm.com> List-Id: References: <20170620043035.avphtcoght2iiyug@oak.ozlabs.ibm.com> <20170620123907.GC10325@potion> <3bc0aeed-136b-5b7f-03a4-17b3aae31842@redhat.com> <20170620151700.GF10325@potion> In-Reply-To: <20170620151700.GF10325@potion> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Radim =?utf-8?B?S3LEjW3DocWZ?= Cc: Paolo Bonzini , kvm@vger.kernel.org, David Gibson , kvm-ppc@vger.kernel.org On Tue, Jun 20, 2017 at 05:17:01PM +0200, Radim Krčmář wrote: > 2017-06-20 14:55+0200, Paolo Bonzini: > > On 20/06/2017 14:39, Radim Krčmář wrote: > > > 2017-06-20 14:30+1000, Paul Mackerras: > > >> Paolo, > > >> > > >> Please do a pull from my kvm-ppc-fixes branch to get 6 commits that I > > >> would like to have go into 4.12, because they fix problems that could > > >> cause hangs or crashes in the host (the first and last commit, but > > >> only on POWER9 systems), or they fix problems that could allow guests > > >> to potentially affect or disrupt the execution of the controlling > > >> userspace (the other four). They are all marked to go to stable. > > > > > > Pulled, but only locally at the moment -- would you like me to apply > > > "[PATCH v2] KVM: MIPS: Fix maybe-uninitialized build failure" directly? > > > > Why not, isn't the tree yours? :) > > Right, and the arch doesn't even match ... let's forget I asked. :) > > Pushed into kvm/master, thanks. Thanks. On a related note, we still have the warning in virt/kvm/kvm_main.c for CONFIG_SMP=n builds about the variable 'wait' being unused in kvm_make_all_cpus_request(), because smp_call_function_many() doesn't reference its 'wait' argument for uniprocessor configs. This then causes the build to fail on powerpc because kvm_main.c actually gets compiled under arch/powerpc, and we use -Werror for arch/powerpc by default. Paolo posted a sketch of a patch to make smp_call_function_many be a static inline instead of a macro on UP, but it wasn't quite right and no-one sent it anywhere. Paolo, if you're OK with me cleaning it up and sending it on, I'll do that. Paul.