From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbdFUR3S (ORCPT ); Wed, 21 Jun 2017 13:29:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:46660 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbdFUR3R (ORCPT ); Wed, 21 Jun 2017 13:29:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F36D217C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 21 Jun 2017 14:29:11 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Andi Kleen , Peter Zijlstra , Jiri Olsa , Namhyung Kim , Wang Nan , David Ahern , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 20/37] perf script: Add 'synth' event type for synthesized events Message-ID: <20170621172911.GQ13640@kernel.org> References: <1495786658-18063-21-git-send-email-adrian.hunter@intel.com> <1498040239-32418-1-git-send-email-adrian.hunter@intel.com> <20170621135145.GO13640@kernel.org> <66cdc4e6-58a4-e365-8a76-112daf71baf9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66cdc4e6-58a4-e365-8a76-112daf71baf9@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jun 21, 2017 at 07:41:04PM +0300, Adrian Hunter escreveu: > On 06/21/2017 04:51 PM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Jun 21, 2017 at 01:17:19PM +0300, Adrian Hunter escreveu: > >> +++ b/tools/perf/util/event.h > >> @@ -252,6 +252,9 @@ enum auxtrace_error_type { > >> PERF_AUXTRACE_ERROR_MAX > >> }; > > > >> +/* Attribute type for custom synthesized events */ > >> +#define PERF_TYPE_SYNTH 3000000000 > > > > Why don't you make it PERF_TYPE_MAX and bump PERF_TYPE_MAX by one? I.e. > > this way we have what can be in attr.type in a nice enumeration, can > > validate it more easily (attr.type < PERF_TYPE_MAX) and will not need to > > do those conversions to/from OUTPUT_TYPE_/PERF_TYPE_). > PERF_TYPE_ is dynamically allocated above PERF_TYPE_MAX for PMUs. Presently > perf_pmu_register() calls idr_alloc() with end=0 which limits the allocation > to INT_MAX. Oh, forgot about that, guess a comment right beside PERF_TYPE_MAX is in demand :-\ So why not: /* * PERF_TYPE_ is dynamically allocated above PERF_TYPE_MAX for PMUs. Presently * perf_pmu_register() calls idr_alloc() with end=0 which limits the allocation * to INT_MAX. */ #define PERF_TYPE_SYNTH (INT_MAX + 1L) I.e. wouldn't be some arbitrarily huge value, but one right after what was defined as the area for the dynamicly allocated PERF_TYPE_ "namespace" for PMUs, right? > > Peter: now its not the PERF_RECORD_ namespace that userspaces want a > > chunk of, its PERF_TYPE_, which so far has been pretty stable, grabing > > _one_ for event synthesizing things like Intel PT (and ARM's coresight, > > I think) directly at include/uapi/linux/perf_event.h's perf_type_id enum > > looks cleaner, no? - Arnaldo