All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH 14/31] vga: use DIV_ROUND_UP
Date: Thu, 22 Jun 2017 14:41:47 +0200	[thread overview]
Message-ID: <20170622124204.19407-15-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20170622124204.19407-1-marcandre.lureau@redhat.com>

I used the clang-tidy qemu-round check to generate the fix:
https://github.com/elmarco/clang-tools-extra

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/display/vga.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/display/vga.c b/hw/display/vga.c
index dcc95f88e2..c2d3e8f54b 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1621,7 +1621,7 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
            s->line_compare, sr(s, VGA_SEQ_CLOCK_MODE));
 #endif
     addr1 = (s->start_addr * 4);
-    bwidth = (width * bits + 7) / 8;
+    bwidth = DIV_ROUND_UP(width * bits, 8);
     y_start = -1;
     d = surface_data(surface);
     linesize = surface_stride(surface);
-- 
2.13.1.395.gf7b71de06

  parent reply	other threads:[~2017-06-22 12:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 12:41 [Qemu-devel] [PATCH 00/31] Refactoring with clang-tidy Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 01/31] i386: use ROUND_UP macro Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 02/31] vnc: use QEMU_ALIGN_DOWN Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 03/31] vhdx: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 04/31] vhost: " Marc-André Lureau
2017-06-22 18:49   ` Michael S. Tsirkin
2017-06-22 12:41 ` [Qemu-devel] [PATCH 05/31] i8254: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 06/31] pcspk: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 07/31] dmg: use DIV_ROUND_UP Marc-André Lureau
2017-06-23  9:56   ` Stefan Hajnoczi
2017-06-22 12:41 ` [Qemu-devel] [PATCH 08/31] qcow2: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 09/31] vpc: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 10/31] vvfat: " Marc-André Lureau
2017-07-03 11:38   ` [Qemu-devel] [Qemu-block] " Eric Blake
2017-06-22 12:41 ` [Qemu-devel] [PATCH 11/31] vnc: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 12/31] slirp: " Marc-André Lureau
2017-06-23  0:19   ` Samuel Thibault
2017-06-22 12:41 ` [Qemu-devel] [PATCH 13/31] ui: " Marc-André Lureau
2017-06-22 12:41 ` Marc-André Lureau [this message]
2017-06-22 12:41 ` [Qemu-devel] [PATCH 15/31] virtio-gpu: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 16/31] monitor: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 17/31] console: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 18/31] virtio-serial: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 19/31] piix: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 20/31] q35: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 21/31] usb-hub: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 22/31] msix: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 23/31] ppc: " Marc-André Lureau
2017-07-02  3:04   ` David Gibson
2017-06-22 12:41 ` [Qemu-devel] [PATCH 24/31] i386/dump: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 25/31] kvm: " Marc-André Lureau
2017-06-22 12:41 ` [Qemu-devel] [PATCH 26/31] decnumber: " Marc-André Lureau
2017-06-22 12:42 ` [Qemu-devel] [PATCH 27/31] i386: introduce ELF_NOTE_SIZE macro Marc-André Lureau
2017-06-22 12:42 ` [Qemu-devel] [PATCH 28/31] 9pfs: replace g_malloc()+memcpy() with g_memdup() Marc-André Lureau
2017-06-22 13:08   ` Greg Kurz
2017-06-22 12:42 ` [Qemu-devel] [PATCH 29/31] i386: " Marc-André Lureau
2017-06-22 12:42 ` [Qemu-devel] [PATCH 30/31] test-iov: " Marc-André Lureau
2017-06-22 12:42 ` [Qemu-devel] [PATCH 31/31] eepro100: " Marc-André Lureau
2017-06-22 13:09   ` Stefan Weil
2017-06-23  8:46     ` Jason Wang
2017-06-22 12:59 ` [Qemu-devel] [PATCH 00/31] Refactoring with clang-tidy Peter Maydell
2017-06-22 13:54 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170622124204.19407-15-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.