From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753288AbdFVMtr (ORCPT <rfc822;w@1wt.eu>);
        Thu, 22 Jun 2017 08:49:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47520 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753222AbdFVMtp (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 22 Jun 2017 08:49:45 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6322D40F3F
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jpoimboe@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 6322D40F3F
Date: Thu, 22 Jun 2017 07:49:41 -0500
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
        live-patching@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC PATCH 04/10] objtool: add undwarf debuginfo generation
Message-ID: <20170622124941.3prtsrpuavzasafy@treble>
References: <cover.1496293620.git.jpoimboe@redhat.com>
 <848a1c6a1384ff5dd40ff204e1ace7e07559fde0.1496293620.git.jpoimboe@redhat.com>
 <e53f3bde-3528-6c50-e322-0947cfb4dcdc@suse.cz>
 <20170614132732.52etdpbvtbv7os6m@treble>
 <43b8b50a-238b-aade-3fc7-ad2595de0f4e@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <43b8b50a-238b-aade-3fc7-ad2595de0f4e@suse.cz>
User-Agent: Mutt/1.6.0.1 (2016-04-01)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 22 Jun 2017 12:49:44 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 22, 2017 at 09:47:46AM +0200, Jiri Slaby wrote:
> On 06/14/2017, 03:27 PM, Josh Poimboeuf wrote:
> > I agree with all your comments, will fix them all.  Thanks for the
> > review.
> 
> This is not the correct way:
> ++      if (flags & O_WRONLY)
> ++              cmd = ELF_C_WRITE;
> ++      else if (flags & O_RDWR)
> ++              cmd = ELF_C_RDWR;
> ++      else
> ++              cmd = ELF_C_READ_MMAP;
> 
> For this particular codeflow, it works, but it should be:
> (flags & O_ACCMODE) == O_WRONLY
>                     == O_RDWR

Ok, thanks.  I see you started reviewing v2 early ;-)  It's almost ready
to post, will send the patches next week.

-- 
Josh