From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754474AbdFWFsh (ORCPT ); Fri, 23 Jun 2017 01:48:37 -0400 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:55448 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754330AbdFWFsd (ORCPT ); Fri, 23 Jun 2017 01:48:33 -0400 X-Original-SENDERIP: 156.147.1.127 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , kernel-team@lge.com, Masami Hiramatsu , Andi Kleen , Adrian Hunter , Wang Nan Subject: [PATCH/RFC 2/9] perf tools: Remove duplicate code Date: Fri, 23 Jun 2017 14:48:20 +0900 Message-Id: <20170623054827.3828-3-namhyung@kernel.org> X-Mailer: git-send-email 2.13.1 In-Reply-To: <20170623054827.3828-1-namhyung@kernel.org> References: <20170623054827.3828-1-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The map_groups__set_module_path() is called after machine__create_module() which sets build-id and symtab type already. Also remove is_kmod_dso() as there's no user anymore. Cc: Adrian Hunter Cc: Wang Nan Signed-off-by: Namhyung Kim --- tools/perf/util/machine.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index d7f31cb0a4cb..d838f893e639 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1024,12 +1024,6 @@ static char *get_kernel_version(const char *root_dir) return strdup(name); } -static bool is_kmod_dso(struct dso *dso) -{ - return dso->symtab_type == DSO_BINARY_TYPE__SYSTEM_PATH_KMODULE || - dso->symtab_type == DSO_BINARY_TYPE__GUEST_KMODULE; -} - static int map_groups__set_module_path(struct map_groups *mg, const char *path, struct kmod_path *m) { @@ -1045,15 +1039,6 @@ static int map_groups__set_module_path(struct map_groups *mg, const char *path, return -ENOMEM; dso__set_long_name(map->dso, long_name, true); - dso__kernel_module_get_build_id(map->dso, ""); - - /* - * Full name could reveal us kmod compression, so - * we need to update the symtab_type if needed. - */ - if (m->comp && is_kmod_dso(map->dso)) - map->dso->symtab_type++; - return 0; } -- 2.13.1