All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
	Dmitri Prokhorov <Dmitry.Prohorov@intel.com>,
	Valery Cherepennikov <valery.cherepennikov@intel.com>,
	David Carrillo-Cisneros <davidcc@google.com>,
	Stephane Eranian <eranian@google.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/4] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi
Date: Fri, 23 Jun 2017 15:58:40 +0100	[thread overview]
Message-ID: <20170623145826.GA26953@leverpostej> (raw)
In-Reply-To: <81fc4d10-1245-59e8-8575-1f790c4e1097@linux.intel.com>

Hi,

As a heads-up, it looks like something is mangling these patches. I see
that the @@ lines in patches are line-wrapped, which from git am's PoV
means the patches are corrupt.

On Wed, Jun 21, 2017 at 06:39:24PM +0300, Alexey Budankov wrote:
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index bc63f8d..fc37e30 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -1458,8 +1458,12 @@ static enum event_type_t
> get_event_type(struct perf_event *event)

e.g. the last two lines above should be one line.

> @@ -1467,6 +1471,223 @@ ctx_group_list(struct perf_event *event,
> struct perf_event_context *ctx)

Likewise.

> @@ -1485,12 +1706,8 @@ list_add_event(struct perf_event *event,
> struct perf_event_context *ctx)

Likewise.

> @@ -1681,7 +1898,7 @@ list_del_event(struct perf_event *event,
> struct perf_event_context *ctx)

Likewise.

... and so on throughout the patch.

I'm only seeing this on patches from you, and I see this both from my
arm.com account and a gmail account subscribed to LKML, whether I export
this from mutt or from the gmail web interface.

Can you check if your MTA is doing something here?

It's possible to fix this up manually, but it's rather tedious.

Thanks,
Mark.

      reply	other threads:[~2017-06-23 14:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-21 15:39 [PATCH v4 1/4] perf/core: addressing 4x slowdown during per-process profiling of STREAM benchmark on Intel Xeon Phi Alexey Budankov
2017-06-23 14:58 ` Mark Rutland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170623145826.GA26953@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=Dmitry.Prohorov@intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=alexey.budankov@linux.intel.com \
    --cc=davidcc@google.com \
    --cc=eranian@google.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=valery.cherepennikov@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.