Re: [OSSTEST PATCH v11 20/20] Introduce flight for stable branches of OpenStack

[Anthony PERARD <anthony.perard@citrix.com>]

On Fri, Jun 23, 2017 at 02:58:25PM +0100, Ian Jackson wrote:
> Anthony PERARD writes ("[OSSTEST PATCH v11 20/20] Introduce flight for stable branches of OpenStack"):
> > OpenStack have many different repo which should be in sync, so this
> > patch should grab the revisions of the stable branch of every OpenStack
> > tree. Tempest does not have stable branch and should be able to test any
> > OpenStack version.
> 
> I'm afraid I don't understand this patch.
> 
> Partly, I think it needs to be squashed with the original patch
> introducing `openstack-nova' as a branch.  While your series has a
> number of things where a thing is introduced and then later patched,
> and this is largely OK, I think it is too confusing to have a whole
> branch appear and disappear like this (without ever having been
> run for real).

Yes, I can do that.

> > -openstack-nova)
> > +openstack-tempest*)
> > +        # OpenStack Tempest does not have stable branches and should work with any
> 
> Your comment lines need wrapping to ~70-75 (here and later).
> 
> > +        # version of OpenStack
> >  	repo_tree_rev_fetch_git openstack-nova \
> >  		$TREE_OPENSTACK_NOVA master $LOCALREV_OPENSTACK_NOVA
> >  	;;
> > +openstack-*-*)
> 
> I think you need to document what your openstack-*-* branch names are
> going to be.
> 
> And, you make provision here for branches openstack-tempest* but you
> don't add any such branches to cr-for-branches.
> 
> I forget what decisions we made about the push gate logic for the
> various openstack branches.  I think it would be worth explicitly
> writing this down in tree (in a comment in ap-fetch-* perhaps).

We decided to track only nova.git, and let osstest clone other trees and
checkout the HEAD (by having REVISION_* empty). That is fine if we track
"master" of nova.git.

The issue now is if we want to track a branch of OpenStack, like
"stable/ocata" (which is the latest release), we need to have all trees
(nova.git, devstack.git, ...) checkout the same branch. (tempest.git
does not have release specific branch.)

I think this patch is confusing because I originally try to use osstest
scripts to find which commit to use for every trees and so have add the
necessary into ./ap-fetch-version. But I could not make that works
without duplicating some functions and so went with writing
'origin/stable/ocata' into REVISION_*.


In term of osstest branches, in cr-for-branches, I would like only one
branch. 'openstack-nova-ocata' would be a the branch that test the
OpenStack release named 'Ocata'. Later, once this branch run smoothly,
we can add a branch to test 'master', the development branch of
OpenStack, it was called 'openstack-nova' in the original 3 patch of
this patch series.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel