From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754757AbdFWV6o (ORCPT ); Fri, 23 Jun 2017 17:58:44 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35351 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754667AbdFWV6m (ORCPT ); Fri, 23 Jun 2017 17:58:42 -0400 Date: Fri, 23 Jun 2017 16:58:14 -0500 From: Rob Herring To: Jose Abreu Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Carlos Palminha , Mark Rutland , Mauro Carvalho Chehab , Hans Verkuil , Sylwester Nawrocki Subject: Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX Message-ID: <20170623215814.ase6g4lbukaeqak2@rob-hp-laptop> References: <8ebe3dfcd61a1c8cfa99102c376ad26b2bfbd254.1497978963.git.joabreu@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ebe3dfcd61a1c8cfa99102c376ad26b2bfbd254.1497978963.git.joabreu@synopsys.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote: > Document the bindings for the Synopsys Designware HDMI RX. > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Rob Herring > Cc: Mark Rutland > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Cc: Sylwester Nawrocki > > Changes from v3: > - Document the new DT bindings suggested by Sylwester > Changes from v2: > - Document edid-phandle property > --- > .../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 70 ++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt > > diff --git a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt > new file mode 100644 > index 0000000..efb0ac3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt > @@ -0,0 +1,70 @@ > +Synopsys DesignWare HDMI RX Decoder > +=================================== > + > +This document defines device tree properties for the Synopsys DesignWare HDMI > +RX Decoder (DWC HDMI RX). It doesn't constitute a device tree binding > +specification by itself but is meant to be referenced by platform-specific > +device tree bindings. > + > +When referenced from platform device tree bindings the properties defined in > +this document are defined as follows. > + > +- compatible: Shall be "snps,dw-hdmi-rx". > + > +- reg: Memory mapped base address and length of the DWC HDMI RX registers. > + > +- interrupts: Reference to the DWC HDMI RX interrupt and 5v sense interrupt. > + > +- clocks: Phandle to the config clock block. > + > +- clock-names: Shall be "cfg-clk". "-clk" is redundant. Seems strange that this is the only clock. The only other clock is the HDMI clock from the HDMI transmitter. > + > +- edid-phandle: phandle to the EDID handler block. > + > +- #address-cells: Shall be 1. > + > +- #size-cells: Shall be 0. > + > +You also have to create a subnode for phy driver. Phy properties are as follows. > + > +- compatible: Shall be "snps,dw-hdmi-phy-e405". > + > +- reg: Shall be JTAG address of phy. > + > +- clocks: Phandle for cfg clock. > + > +- clock-names:Shall be "cfg-clk". > + > +A sample binding is now provided. The compatible string is for a SoC which has > +has a Synopsys Designware HDMI RX decoder inside. > + > +Example: > + > +dw_hdmi_soc: dw-hdmi-soc@0 { > + compatible = "snps,dw-hdmi-soc"; Not documented. > + reg = <0x11c00 0x1000>; /* EDIDs */ > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + dw_hdmi_rx@0 { hdmi-rx@0 > + compatible = "snps,dw-hdmi-rx"; > + reg = <0x0 0x10000>; > + interrupts = <1 2>; > + edid-phandle = <&dw_hdmi_soc>; Don't need this if it is the parent node. > + > + clocks = <&dw_hdmi_refclk>; > + clock-names = "cfg-clk"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dw_hdmi_phy_e405@fc { hdmi-phy@fc > + compatible = "snps,dw-hdmi-phy-e405"; > + reg = <0xfc>; > + > + clocks = <&dw_hdmi_refclk>; > + clock-names = "cfg-clk"; > + }; > + }; > +}; > -- > 1.9.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v4 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX Date: Fri, 23 Jun 2017 16:58:14 -0500 Message-ID: <20170623215814.ase6g4lbukaeqak2@rob-hp-laptop> References: <8ebe3dfcd61a1c8cfa99102c376ad26b2bfbd254.1497978963.git.joabreu@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <8ebe3dfcd61a1c8cfa99102c376ad26b2bfbd254.1497978963.git.joabreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jose Abreu Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Carlos Palminha , Mark Rutland , Mauro Carvalho Chehab , Hans Verkuil , Sylwester Nawrocki List-Id: devicetree@vger.kernel.org On Tue, Jun 20, 2017 at 06:26:12PM +0100, Jose Abreu wrote: > Document the bindings for the Synopsys Designware HDMI RX. > > Signed-off-by: Jose Abreu > Cc: Carlos Palminha > Cc: Rob Herring > Cc: Mark Rutland > Cc: Mauro Carvalho Chehab > Cc: Hans Verkuil > Cc: Sylwester Nawrocki > > Changes from v3: > - Document the new DT bindings suggested by Sylwester > Changes from v2: > - Document edid-phandle property > --- > .../devicetree/bindings/media/snps,dw-hdmi-rx.txt | 70 ++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt > > diff --git a/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt > new file mode 100644 > index 0000000..efb0ac3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.txt > @@ -0,0 +1,70 @@ > +Synopsys DesignWare HDMI RX Decoder > +=================================== > + > +This document defines device tree properties for the Synopsys DesignWare HDMI > +RX Decoder (DWC HDMI RX). It doesn't constitute a device tree binding > +specification by itself but is meant to be referenced by platform-specific > +device tree bindings. > + > +When referenced from platform device tree bindings the properties defined in > +this document are defined as follows. > + > +- compatible: Shall be "snps,dw-hdmi-rx". > + > +- reg: Memory mapped base address and length of the DWC HDMI RX registers. > + > +- interrupts: Reference to the DWC HDMI RX interrupt and 5v sense interrupt. > + > +- clocks: Phandle to the config clock block. > + > +- clock-names: Shall be "cfg-clk". "-clk" is redundant. Seems strange that this is the only clock. The only other clock is the HDMI clock from the HDMI transmitter. > + > +- edid-phandle: phandle to the EDID handler block. > + > +- #address-cells: Shall be 1. > + > +- #size-cells: Shall be 0. > + > +You also have to create a subnode for phy driver. Phy properties are as follows. > + > +- compatible: Shall be "snps,dw-hdmi-phy-e405". > + > +- reg: Shall be JTAG address of phy. > + > +- clocks: Phandle for cfg clock. > + > +- clock-names:Shall be "cfg-clk". > + > +A sample binding is now provided. The compatible string is for a SoC which has > +has a Synopsys Designware HDMI RX decoder inside. > + > +Example: > + > +dw_hdmi_soc: dw-hdmi-soc@0 { > + compatible = "snps,dw-hdmi-soc"; Not documented. > + reg = <0x11c00 0x1000>; /* EDIDs */ > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + dw_hdmi_rx@0 { hdmi-rx@0 > + compatible = "snps,dw-hdmi-rx"; > + reg = <0x0 0x10000>; > + interrupts = <1 2>; > + edid-phandle = <&dw_hdmi_soc>; Don't need this if it is the parent node. > + > + clocks = <&dw_hdmi_refclk>; > + clock-names = "cfg-clk"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + dw_hdmi_phy_e405@fc { hdmi-phy@fc > + compatible = "snps,dw-hdmi-phy-e405"; > + reg = <0xfc>; > + > + clocks = <&dw_hdmi_refclk>; > + clock-names = "cfg-clk"; > + }; > + }; > +}; > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html