From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbdFZBsl (ORCPT ); Sun, 25 Jun 2017 21:48:41 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:47006 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbdFZBsd (ORCPT ); Sun, 25 Jun 2017 21:48:33 -0400 Date: Sun, 25 Jun 2017 21:48:29 -0400 (EDT) Message-Id: <20170625.214829.1020312191989118292.davem@davemloft.net> To: Jason@zx2c4.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/icmp: restore source address if packet is NATed From: David Miller In-Reply-To: References: <20170624021727.17835-1-Jason@zx2c4.com> <20170625.114927.1055286919675288173.davem@davemloft.net> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 25 Jun 2017 18:06:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Jason A. Donenfeld" Date: Mon, 26 Jun 2017 00:52:09 +0200 > On Sun, Jun 25, 2017 at 5:49 PM, David Miller wrote: >> You definitely can't just rewrite header fields here either. The >> SKB could be shared, for example. > > I was afraid of that. It's easy to rework this particular patch, > though, if you're still interested in the crufty bolt on approach... > But I think I should investigate the netfilter-only approach instead, > as you suggested. I highly encourage you to continue pursuing the netfilter based approach, and to also discuss it on netfilter-devel which will hit more capable minds than just here on netdev.