From: David Miller <davem@davemloft.net>
To: roopa@cumulusnetworks.com
Cc: linville@tuxdriver.com, netdev@vger.kernel.org,
vidya.chowdary@gmail.com, dustin@cumulusnetworks.com,
olson@cumulusnetworks.com, leedom@chelsio.com,
manojmalviya@chelsio.com, santosh@chelsio.com,
yuval.mintz@qlogic.com, odedw@mellanox.com, ariela@mellanox.com,
galp@mellanox.com, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH net-next 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link
Date: Mon, 26 Jun 2017 23:16:56 -0400 (EDT) [thread overview]
Message-ID: <20170626.231656.1320688765024223168.davem@davemloft.net> (raw)
In-Reply-To: <1498331985-8525-3-git-send-email-roopa@cumulusnetworks.com>
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Sat, 24 Jun 2017 12:19:44 -0700
> @@ -3690,11 +3690,64 @@ void t4_ulprx_read_la(struct adapter *adap, u32 *la_buf)
> FW_PORT_CAP_SPEED_40G | FW_PORT_CAP_SPEED_100G | \
> FW_PORT_CAP_ANEG)
>
> +/* Translate Firmware Port Capabilities Pause specification to Common Code */
> +static inline unsigned int fwcap_to_cc_pause(unsigned int fw_pause)
> +{
Do not use "inline" in foo.c files, always let the compiler decide.
Same goes for patch #3.
next prev parent reply other threads:[~2017-06-27 3:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-24 19:19 [PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link Roopa Prabhu
2017-06-24 19:19 ` [PATCH net-next 1/3] net: ethtool: add support for forward error correction modes Roopa Prabhu
2017-06-25 13:38 ` Gal Pressman
2017-06-28 5:46 ` Dustin Byford
2017-06-29 15:49 ` Gal Pressman
2017-06-27 10:22 ` Jakub Kicinski
2017-06-28 6:27 ` Dustin Byford
2017-06-28 6:41 ` Jakub Kicinski
2017-06-28 13:41 ` Andrew Lunn
2017-06-28 21:47 ` Dustin Byford
2017-06-29 1:00 ` Jakub Kicinski
2017-07-06 18:53 ` Casey Leedom
2017-07-06 19:02 ` Jakub Kicinski
2017-07-06 21:06 ` Wyborny, Carolyn
2017-07-06 21:53 ` Casey Leedom
2017-07-06 22:16 ` Wyborny, Carolyn
2017-07-06 22:36 ` Andrew Lunn
2017-07-06 22:37 ` Casey Leedom
2017-07-06 22:33 ` Andrew Lunn
2017-07-06 22:47 ` Casey Leedom
2017-07-06 23:15 ` Andrew Lunn
2017-07-06 23:27 ` Jakub Kicinski
2017-07-06 23:39 ` Casey Leedom
2017-07-07 0:56 ` Andrew Lunn
2017-07-07 1:38 ` Dave Olson
2017-07-06 22:43 ` Jakub Kicinski
2017-07-06 22:57 ` Casey Leedom
2017-06-29 13:30 ` Andrew Lunn
2017-06-24 19:19 ` [PATCH net-next 2/3] cxgb4: core hardware/firmware support for Forward Error Correction on a link Roopa Prabhu
2017-06-27 3:16 ` David Miller [this message]
2017-06-24 19:19 ` [PATCH net-next 3/3] cxgb4: ethtool forward error correction management support Roopa Prabhu
2017-06-24 21:47 ` [PATCH net-next 0/3] ethtool: support for forward error correction mode setting on a link Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626.231656.1320688765024223168.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariela@mellanox.com \
--cc=dustin@cumulusnetworks.com \
--cc=galp@mellanox.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=leedom@chelsio.com \
--cc=linville@tuxdriver.com \
--cc=manojmalviya@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=odedw@mellanox.com \
--cc=olson@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=santosh@chelsio.com \
--cc=vidya.chowdary@gmail.com \
--cc=yuval.mintz@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.