From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751839AbdFZSOV (ORCPT ); Mon, 26 Jun 2017 14:14:21 -0400 Received: from mail-io0-f196.google.com ([209.85.223.196]:33059 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbdFZSOS (ORCPT ); Mon, 26 Jun 2017 14:14:18 -0400 Date: Mon, 26 Jun 2017 13:14:16 -0500 From: Rob Herring To: Fabrice Gasnier Cc: lee.jones@linaro.org, benjamin.gaignard@linaro.org, jic23@kernel.org, thierry.reding@gmail.com, mark.rutland@arm.com, alexandre.torgue@st.com, mcoquelin.stm32@gmail.com, benjamin.gaignard@st.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v2 5/8] dt-bindings: iio: Add STM32 LPTimer trigger binding Message-ID: <20170626181416.b7wr6wswuzeasuks@rob-hp-laptop> References: <1498055415-31513-1-git-send-email-fabrice.gasnier@st.com> <1498055415-31513-6-git-send-email-fabrice.gasnier@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498055415-31513-6-git-send-email-fabrice.gasnier@st.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2017 at 04:30:12PM +0200, Fabrice Gasnier wrote: > Add documentation for STMicroelectronics STM32 Low-Power Timer Trigger > binding. > > Signed-off-by: Fabrice Gasnier > --- > Changes in v2: > - s/Low Power/Low-Power > - remove leading 0x in example (parent node) > - improve reg property description > --- > .../bindings/iio/timer/stm32-lptimer-trigger.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > > diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt b/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > new file mode 100644 > index 0000000..466d99f > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > @@ -0,0 +1,23 @@ > +STMicroelectronics STM32 Low-Power Timer Trigger > + > +STM32 Low-Power Timer provides trigger source (LPTIM output) that can be used > +by STM32 internal ADC and/or DAC. > + > +Must be a sub-node of an STM32 Low-Power Timer device tree node. > +See ../mfd/stm32-lptimer.txt for details about the parent node. > + > +Required properties: > +- compatible: Must be "st,stm32-lptimer-trigger". > +- reg: Selects trigger hardware block. Must be 0, 1 or 2 > + respectively for lptimer1, lptimer2 or lptimer3 > + trigger output. I guess this answers my question. However, this seems like abuse of the reg prop. This should not be how you select a trigger. The DT should describe all the h/w blocks and then the adc connection is a separate property. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 5/8] dt-bindings: iio: Add STM32 LPTimer trigger binding Date: Mon, 26 Jun 2017 13:14:16 -0500 Message-ID: <20170626181416.b7wr6wswuzeasuks@rob-hp-laptop> References: <1498055415-31513-1-git-send-email-fabrice.gasnier@st.com> <1498055415-31513-6-git-send-email-fabrice.gasnier@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1498055415-31513-6-git-send-email-fabrice.gasnier-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabrice Gasnier Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, benjamin.gaignard-qxv4g6HH51o@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Jun 21, 2017 at 04:30:12PM +0200, Fabrice Gasnier wrote: > Add documentation for STMicroelectronics STM32 Low-Power Timer Trigger > binding. > > Signed-off-by: Fabrice Gasnier > --- > Changes in v2: > - s/Low Power/Low-Power > - remove leading 0x in example (parent node) > - improve reg property description > --- > .../bindings/iio/timer/stm32-lptimer-trigger.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > > diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt b/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > new file mode 100644 > index 0000000..466d99f > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > @@ -0,0 +1,23 @@ > +STMicroelectronics STM32 Low-Power Timer Trigger > + > +STM32 Low-Power Timer provides trigger source (LPTIM output) that can be used > +by STM32 internal ADC and/or DAC. > + > +Must be a sub-node of an STM32 Low-Power Timer device tree node. > +See ../mfd/stm32-lptimer.txt for details about the parent node. > + > +Required properties: > +- compatible: Must be "st,stm32-lptimer-trigger". > +- reg: Selects trigger hardware block. Must be 0, 1 or 2 > + respectively for lptimer1, lptimer2 or lptimer3 > + trigger output. I guess this answers my question. However, this seems like abuse of the reg prop. This should not be how you select a trigger. The DT should describe all the h/w blocks and then the adc connection is a separate property. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 26 Jun 2017 13:14:16 -0500 Subject: [PATCH v2 5/8] dt-bindings: iio: Add STM32 LPTimer trigger binding In-Reply-To: <1498055415-31513-6-git-send-email-fabrice.gasnier@st.com> References: <1498055415-31513-1-git-send-email-fabrice.gasnier@st.com> <1498055415-31513-6-git-send-email-fabrice.gasnier@st.com> Message-ID: <20170626181416.b7wr6wswuzeasuks@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Jun 21, 2017 at 04:30:12PM +0200, Fabrice Gasnier wrote: > Add documentation for STMicroelectronics STM32 Low-Power Timer Trigger > binding. > > Signed-off-by: Fabrice Gasnier > --- > Changes in v2: > - s/Low Power/Low-Power > - remove leading 0x in example (parent node) > - improve reg property description > --- > .../bindings/iio/timer/stm32-lptimer-trigger.txt | 23 ++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > > diff --git a/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt b/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > new file mode 100644 > index 0000000..466d99f > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/timer/stm32-lptimer-trigger.txt > @@ -0,0 +1,23 @@ > +STMicroelectronics STM32 Low-Power Timer Trigger > + > +STM32 Low-Power Timer provides trigger source (LPTIM output) that can be used > +by STM32 internal ADC and/or DAC. > + > +Must be a sub-node of an STM32 Low-Power Timer device tree node. > +See ../mfd/stm32-lptimer.txt for details about the parent node. > + > +Required properties: > +- compatible: Must be "st,stm32-lptimer-trigger". > +- reg: Selects trigger hardware block. Must be 0, 1 or 2 > + respectively for lptimer1, lptimer2 or lptimer3 > + trigger output. I guess this answers my question. However, this seems like abuse of the reg prop. This should not be how you select a trigger. The DT should describe all the h/w blocks and then the adc connection is a separate property. Rob