From: Rob Herring <robh@kernel.org>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: linus.walleij@linaro.org, andy.shevchenko@gmail.com,
dongas86@gmail.com, geert+renesas@glider.be,
Chris.Brandt@renesas.com, laurent.pinchart@ideasonboard.com,
mark.rutland@arm.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: generic: Add output-enable property
Date: Mon, 26 Jun 2017 13:40:50 -0500 [thread overview]
Message-ID: <20170626184050.k4fibk5m42f47sug@rob-hp-laptop> (raw)
In-Reply-To: <1498125658-14554-1-git-send-email-jacopo+renesas@jmondi.org>
On Thu, Jun 22, 2017 at 12:00:58PM +0200, Jacopo Mondi wrote:
> Add output-enable generic pin configuration property.
> This properties allows enabling/disabling pin's output capabilities
> without actually driving any value on the line.
>
> ---
> v1->v2:
> - Expand the property description as suggested by Laurent. I ended up
> mentioning the in-famous output buffer :)
>
> One (more) question to GPIO people on:
> + PCONFDUMP(PIN_CONFIG_OUTPUT_ENABLE, "output enabled", NULL, false),
>
> I copied this from INPUT_ENABLE where arguments 2 and 3 passed to PCONFDUMP are
> NULL and false even if the property has an argument, used to enable/disable
> the input mode. Is this intended? Should that be turned instead to
> - PCONFDUMP(PIN_CONFIG_INPUT_ENABLE, "input enabled", NULL, false),
> + PCONFDUMP(PIN_CONFIG_INPUT_ENABLE, "input enabled", "enabled", true),
>
> Note that the same applies to most of the properties that have an
> "enable"/"disable" argument. Just to make sure this is done on purpose.
>
> Thanks
> j
> .../devicetree/bindings/pinctrl/pinctrl-bindings.txt | 2 ++
Acked-by: Rob Herring <robh@kernel.org>
> drivers/pinctrl/pinconf-generic.c | 3 +++
> include/linux/pinctrl/pinconf-generic.h | 15 +++++++++++----
> 3 files changed, 16 insertions(+), 4 deletions(-)
next prev parent reply other threads:[~2017-06-26 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-22 10:00 [PATCH v2] pinctrl: generic: Add output-enable property Jacopo Mondi
2017-06-26 18:40 ` Rob Herring [this message]
2017-06-29 12:33 ` Linus Walleij
2017-06-29 14:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170626184050.k4fibk5m42f47sug@rob-hp-laptop \
--to=robh@kernel.org \
--cc=Chris.Brandt@renesas.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dongas86@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.