From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751470AbdFZTVV (ORCPT ); Mon, 26 Jun 2017 15:21:21 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:57033 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbdFZTVM (ORCPT ); Mon, 26 Jun 2017 15:21:12 -0400 Date: Mon, 26 Jun 2017 21:21:00 +0200 From: Maxime Ripard To: Chen-Yu Tsai Cc: Danny Milosavljevic , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linux-ALSA , linux-arm-kernel , linux-kernel , linux-sunxi Subject: Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls. Message-ID: <20170626192100.h5o366tawcnkqosx@flea.lan> References: <20170624062419.23778-1-dannym@scratchpost.org> <20170624062419.23778-6-dannym@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rtkmkjogvbtycwif" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rtkmkjogvbtycwif Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 26, 2017 at 09:48:59AM +0800, Chen-Yu Tsai wrote: > On Sat, Jun 24, 2017 at 2:24 PM, Danny Milosavljevic > wrote: > > Since it's now possible to have a DAPM mixer control with multiple chan= nels, > > use it to cut down the total number of controls. > > > > Signed-off-by: Danny Milosavljevic > > --- > > sound/soc/sunxi/sun4i-codec.c | 27 ++++++++++++--------------- > > 1 file changed, 12 insertions(+), 15 deletions(-) > > > > diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-code= c.c > > index c69b55c..3718137 100644 > > --- a/sound/soc/sunxi/sun4i-codec.c > > +++ b/sound/soc/sunxi/sun4i-codec.c > > @@ -685,15 +685,12 @@ static const struct snd_kcontrol_new sun7i_codec_= extra_controls[] =3D { > > sun7i_codec_micin_preamp_gain_scale), > > }; > > > > -static const struct snd_kcontrol_new sun4i_codec_left_mixer_controls[]= =3D { > > - SOC_DAPM_SINGLE("Left DAC Playback Switch", SUN4I_CODEC_DAC_ACT= L, > > - SUN4I_CODEC_DAC_ACTL_LDACLMIXS, 1, 0), > > -}; > > - > > -static const struct snd_kcontrol_new sun4i_codec_right_mixer_controls[= ] =3D { > > - SOC_DAPM_SINGLE("Right DAC Playback Switch", SUN4I_CODEC_DAC_AC= TL, > > +static const struct snd_kcontrol_new sun4i_codec_mixer_controls[] =3D { > > + SOC_DAPM_DOUBLE("DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > + SUN4I_CODEC_DAC_ACTL_LDACLMIXS, > > SUN4I_CODEC_DAC_ACTL_RDACRMIXS, 1, 0), >=20 > This changes the mixer control names exposed to userspace. While I think > consolidating mixer controls is nice, giving the user a less cluttered > view, I'm not sure about the changing a possible userspace ABI. >=20 > Maxime, ALSA and ASoC people, any comments about this? Yeah, breaking userspace is definitely not ok. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --rtkmkjogvbtycwif Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJZUV6cAAoJEBx+YmzsjxAgr0AP/AvQd+zBh6qc8bnnGhGdAQE2 FR3dLTaSbVjhVWQ/C+2ub1lyOKMOekMRyLAejolsRO3PYuna+eYCxPNmYmU4Grv7 gP40LfCmxAfyvZvA0L+Jfxj+TDNVjtYSXi/CbxAgC/mw0Lty3OOz6nYu+lpkwmLH b3RSEZAPWDqlLfaU3yoeLSQIYUsr2sCF0MGmWCvGKUHlTDaCsL1X4feO/5vrXvmz Oqt4R6fkVjjfzCoyBj7e0UOCyAefPbLVtI9YlT1deD0rDWE3b/hrBpykfFW91re8 SxnieZvMJipHiJL0MtUAsiMIGNmquQ+AxYa+6AN5QYExsWM+b85OZlGgHjamiEKM 1T6mfyVTe69XMQH8GJwUbysDmYTlBufHRDQkdRSvo/O/EGnNtMCuWEnPJzCvY3zB RIP29tRO0R1Fr9q1+3YRdsjo3/QSbYv+s8mbYv0b2LyZx00VJTVtuuV4TtED+En3 oSPnRnMRK2agRDZ+KAyNN8irt6RoQK56PUWzXNSUVrEYquc9rCP+V03fWpP4nSwU Z1TXiS+c/JL2plTI1R4VgPizBybQDc/qsSeqnj8KB3Tk0T591ZFosQxH6f3oHo76 pJ4KeDcnJNYrgaBOgDd0FUf2cjB/xzv6DMJTyiBEWrfq+vRsr5C7HM4st6rIZ9rY siZWxNmIYgEE6r2hLjbH =kVST -----END PGP SIGNATURE----- --rtkmkjogvbtycwif-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls. Date: Mon, 26 Jun 2017 21:21:00 +0200 Message-ID: <20170626192100.h5o366tawcnkqosx@flea.lan> References: <20170624062419.23778-1-dannym@scratchpost.org> <20170624062419.23778-6-dannym@scratchpost.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rtkmkjogvbtycwif" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Danny Milosavljevic , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linux-ALSA , linux-arm-kernel , linux-kernel , linux-sunxi List-Id: alsa-devel@alsa-project.org --rtkmkjogvbtycwif Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Mon, Jun 26, 2017 at 09:48:59AM +0800, Chen-Yu Tsai wrote: > On Sat, Jun 24, 2017 at 2:24 PM, Danny Milosavljevic > wrote: > > Since it's now possible to have a DAPM mixer control with multiple channels, > > use it to cut down the total number of controls. > > > > Signed-off-by: Danny Milosavljevic > > --- > > sound/soc/sunxi/sun4i-codec.c | 27 ++++++++++++--------------- > > 1 file changed, 12 insertions(+), 15 deletions(-) > > > > diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c > > index c69b55c..3718137 100644 > > --- a/sound/soc/sunxi/sun4i-codec.c > > +++ b/sound/soc/sunxi/sun4i-codec.c > > @@ -685,15 +685,12 @@ static const struct snd_kcontrol_new sun7i_codec_extra_controls[] = { > > sun7i_codec_micin_preamp_gain_scale), > > }; > > > > -static const struct snd_kcontrol_new sun4i_codec_left_mixer_controls[] = { > > - SOC_DAPM_SINGLE("Left DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > - SUN4I_CODEC_DAC_ACTL_LDACLMIXS, 1, 0), > > -}; > > - > > -static const struct snd_kcontrol_new sun4i_codec_right_mixer_controls[] = { > > - SOC_DAPM_SINGLE("Right DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > +static const struct snd_kcontrol_new sun4i_codec_mixer_controls[] = { > > + SOC_DAPM_DOUBLE("DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > + SUN4I_CODEC_DAC_ACTL_LDACLMIXS, > > SUN4I_CODEC_DAC_ACTL_RDACRMIXS, 1, 0), > > This changes the mixer control names exposed to userspace. While I think > consolidating mixer controls is nice, giving the user a less cluttered > view, I'm not sure about the changing a possible userspace ABI. > > Maxime, ALSA and ASoC people, any comments about this? Yeah, breaking userspace is definitely not ok. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --rtkmkjogvbtycwif-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@free-electrons.com (Maxime Ripard) Date: Mon, 26 Jun 2017 21:21:00 +0200 Subject: [PATCH v13 05/14] ASoC: sun4i-codec: Merge sun4i_codec_left_mixer_controls and sun4i_codec_right_mixer_controls into sun4i_codec_mixer_controls. In-Reply-To: References: <20170624062419.23778-1-dannym@scratchpost.org> <20170624062419.23778-6-dannym@scratchpost.org> Message-ID: <20170626192100.h5o366tawcnkqosx@flea.lan> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Jun 26, 2017 at 09:48:59AM +0800, Chen-Yu Tsai wrote: > On Sat, Jun 24, 2017 at 2:24 PM, Danny Milosavljevic > wrote: > > Since it's now possible to have a DAPM mixer control with multiple channels, > > use it to cut down the total number of controls. > > > > Signed-off-by: Danny Milosavljevic > > --- > > sound/soc/sunxi/sun4i-codec.c | 27 ++++++++++++--------------- > > 1 file changed, 12 insertions(+), 15 deletions(-) > > > > diff --git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c > > index c69b55c..3718137 100644 > > --- a/sound/soc/sunxi/sun4i-codec.c > > +++ b/sound/soc/sunxi/sun4i-codec.c > > @@ -685,15 +685,12 @@ static const struct snd_kcontrol_new sun7i_codec_extra_controls[] = { > > sun7i_codec_micin_preamp_gain_scale), > > }; > > > > -static const struct snd_kcontrol_new sun4i_codec_left_mixer_controls[] = { > > - SOC_DAPM_SINGLE("Left DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > - SUN4I_CODEC_DAC_ACTL_LDACLMIXS, 1, 0), > > -}; > > - > > -static const struct snd_kcontrol_new sun4i_codec_right_mixer_controls[] = { > > - SOC_DAPM_SINGLE("Right DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > +static const struct snd_kcontrol_new sun4i_codec_mixer_controls[] = { > > + SOC_DAPM_DOUBLE("DAC Playback Switch", SUN4I_CODEC_DAC_ACTL, > > + SUN4I_CODEC_DAC_ACTL_LDACLMIXS, > > SUN4I_CODEC_DAC_ACTL_RDACRMIXS, 1, 0), > > This changes the mixer control names exposed to userspace. While I think > consolidating mixer controls is nice, giving the user a less cluttered > view, I'm not sure about the changing a possible userspace ABI. > > Maxime, ALSA and ASoC people, any comments about this? Yeah, breaking userspace is definitely not ok. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: