From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 Date: Tue, 27 Jun 2017 15:26:12 -0700 Message-ID: <20170627152612.3fabf6fd@xeon-e3> References: <20170522143202.22424-2-michalx.k.jastrzebski@intel.com> <1498470133-29788-1-git-send-email-radu.nicolau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, wenzhuo.lu@intel.com, reshma.pattan@intel.com, michalx.k.jastrzebski@intel.com, deepak.k.jain@intel.com, harry.van.haaren@intel.com, piotrx.t.azarewicz@intel.com To: Radu Nicolau Return-path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id 2EF7B2BE1 for ; Wed, 28 Jun 2017 00:26:20 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id j186so22034730pge.2 for ; Tue, 27 Jun 2017 15:26:20 -0700 (PDT) In-Reply-To: <1498470133-29788-1-git-send-email-radu.nicolau@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 26 Jun 2017 10:42:13 +0100 Radu Nicolau wrote: > From: Michal Jastrzebski > > If-MIB xstats: > ifNumber > ifIndex > ifType > ifMtu > ifSpeed > ifPhysAddress > ifOperStatus > ifLastChange > ifHighSpeed > ifConnectorPresent > ifCounterDiscontinuityTime > > EtherLike-MIB xstats: > dot3PauseOperMode > dot3StatsDuplexStatus > dot3StatsRateControlAbility > dot3StatsRateControlStatus > dot3ControlFunctionsSupported > > -updated in v2: coding style > > Signed-off-by: Piotr Azarewicz > Signed-off-by: Michal Jastrzebski > Signed-off-by: Radu Nicolau Although this maybe the easiest way for Intel, and satisfy a specific user's request. It is not a good way forward for the DPDK project. This must be generic, not specific to device drivers. If implementing a MIB variable requires more information than ethdev API has now, then extend ethdev API first. One of the common things in open source projects, is that when you want to add one new feature for one constrained portion; the maintainers require you to implement a generic solution. This falls into that category.