From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2] drivers/net: add support for IF-MIB and
 EtherLike-MIB for ixgbe
Date: Tue, 27 Jun 2017 15:27:27 -0700
Message-ID: <20170627152727.269f6f52@xeon-e3>
References: <20170522143202.22424-4-michalx.k.jastrzebski@intel.com>
 <1498469947-29496-1-git-send-email-radu.nicolau@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, reshma.pattan@intel.com,
 michalx.k.jastrzebski@intel.com, deepak.k.jain@intel.com,
 harry.van.haaren@intel.com, piotrx.t.azarewicz@intel.com
To: Radu Nicolau <radu.nicolau@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pf0-f170.google.com (mail-pf0-f170.google.com
 [209.85.192.170]) by dpdk.org (Postfix) with ESMTP id A66572BE1
 for <dev@dpdk.org>; Wed, 28 Jun 2017 00:27:29 +0200 (CEST)
Received: by mail-pf0-f170.google.com with SMTP id c73so23203532pfk.2
 for <dev@dpdk.org>; Tue, 27 Jun 2017 15:27:29 -0700 (PDT)
In-Reply-To: <1498469947-29496-1-git-send-email-radu.nicolau@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 26 Jun 2017 10:39:07 +0100
Radu Nicolau <radu.nicolau@intel.com> wrote:

> +static const struct rte_ixgbe_xstats_name_off ixgbe_if_mib_strings[] = {
> +	{"ifNumber", offsetof(struct ixgbe_if_mib_stats, if_number)},
> +	{"ifIndex", offsetof(struct ixgbe_if_mib_stats, if_index)},
> +	{"ifType", offsetof(struct ixgbe_if_mib_stats, if_type)},
> +	{"ifMtu", offsetof(struct ixgbe_if_mib_stats, if_mtu)},
> +	{"ifSpeed", offsetof(struct ixgbe_if_mib_stats, if_speed)},
> +	{"ifPhysAddress", offsetof(struct ixgbe_if_mib_stats, if_phys_address)},
> +	{"ifOperStatus", offsetof(struct ixgbe_if_mib_stats, if_oper_status)},
> +	{"ifLastChange", offsetof(struct ixgbe_if_mib_stats, if_last_change)},
> +	{"ifHighSpeed", offsetof(struct ixgbe_if_mib_stats, if_high_speed)},
> +	{"ifConnectorPresent", offsetof(struct ixgbe_if_mib_stats,
> +			if_connector_present)},
> +	{"ifCounterDiscontinuityTime", offsetof(struct ixgbe_if_mib_stats,
> +			if_counter_discontinuity_time)},

Most of these should not be xstats. Things like if_index, type and MTU are available
through other API's already.