Re: [PATCH 1/3] sha1dc: update from my PR #36

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: ?var Arnfj?r? Bjarmason <avarab@gmail.com>,
	git@vger.kernel.org, Jeff King <peff@peff.net>,
	Michael Kebe <michael.kebe@gmail.com>,
	Adam Dinwoodie <adam@dinwoodie.org>,
	Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH 1/3] sha1dc: update from my PR #36
Date: Tue, 27 Jun 2017 12:31:02 -0400	[thread overview]
Message-ID: <20170627163101.u7lsclnxnl6o7jec@oracle.com> (raw)
In-Reply-To: <xmqqefu52znl.fsf@gitster.mtv.corp.google.com>

* Junio C Hamano <gitster@pobox.com> [170627 11:55]:
> Junio C Hamano <gitster@pobox.com> writes:
> 
> >> +#if (defined(__ARMEB__) || defined(__THUMBEB__) || defined(__AARCH64EB__) || \
> >>       defined(__MIPSEB__) || defined(__MIPSEB) || defined(_MIPSEB) || \
> >>       defined(__sparc))
> >> +/*
> >> + * Should define Big Endian for a whitelist of known processors. See
> >> + * https://sourceforge.net/p/predef/wiki/Endianness/ and
> >> + * http://www.oracle.com/technetwork/server-storage/solaris/portingtosolaris-138514.html
> >> + */
> >>  #define SHA1DC_BIGENDIAN
> >
> > These look sensible.
> 
> By the way, I wonder why this didn't catch the sparc running
> Solaris.  What does Michael's system use to let the software know
> that it is targetted for a Sparc, if not __sparc?
> 

I have issues running the test on my solaris system.  Could you send him
the changes you made on sha1dc in git?  I suspect his platform does
define __sparc.

Cheers,
Liam