From: Harpreet Eli Sangha <harpreet@nestlabs.com>
To: linux-mtd@lists.infradead.org
Cc: david.oberhollenzer@sigma-star.at
Subject: [PATCH] mtd-utils: tests: Fix nandbiterrs Failure Check
Date: Tue, 27 Jun 2017 13:52:26 -0700 [thread overview]
Message-ID: <20170627205226.18734-1-harpreet@nestlabs.com> (raw)
In-Reply-To: <CAOMZO5CPDSsG9oe5ZV-VVxp9BVB=WU_i03LYtPe8LWy+d=5uAw@mail.gmail.com>
From: "Harpreet \"Eli\" Sangha" <harpreet@nestlabs.com>
After a page read, the old failure statistics are compared against the
new failure statistics before the new values are actually read.
Signed-off-by: Harpreet "Eli" Sangha <harpreet@nestlabs.com>
---
tests/mtd-tests/nandbiterrs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/mtd-tests/nandbiterrs.c b/tests/mtd-tests/nandbiterrs.c
index 6acbfee..de9d0dd 100644
--- a/tests/mtd-tests/nandbiterrs.c
+++ b/tests/mtd-tests/nandbiterrs.c
@@ -268,15 +268,15 @@ static int read_page(void)
return -1;
}
+ if (ioctl(fd, ECCGETSTATS, &new) != 0)
+ goto failstats;
+
if (new.failed > old.failed) {
fprintf(stderr, "Failed to recover %d bitflips\n",
new.failed - old.failed);
return -1;
}
- if (ioctl(fd, ECCGETSTATS, &new) != 0)
- goto failstats;
-
return new.corrected - old.corrected;
failstats:
perror("ECCGETSTATS");
--
2.13.2.725.g09c95d1e9-goog
next prev parent reply other threads:[~2017-06-27 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 23:06 [PATCH] mtd-utils: tests: Fix nandbiterrs Failure Check harpreet
2017-06-27 20:11 ` Fabio Estevam
2017-06-27 20:52 ` Harpreet Eli Sangha [this message]
2017-06-28 8:38 ` David Oberhollenzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627205226.18734-1-harpreet@nestlabs.com \
--to=harpreet@nestlabs.com \
--cc=david.oberhollenzer@sigma-star.at \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.