From: Bjorn Helgaas <helgaas@kernel.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: mediatek: change to use the new host bridge interface
Date: Tue, 27 Jun 2017 18:20:57 -0500 [thread overview]
Message-ID: <20170627232057.GK17844@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170627223039.GE17844@bhelgaas-glaptop.roam.corp.google.com>
On Tue, Jun 27, 2017 at 05:30:40PM -0500, Bjorn Helgaas wrote:
> On Tue, Jun 27, 2017 at 05:24:11PM +0800, Ryder Lee wrote:
> > With the introduction of pci_scan_root_bus_bridge() there is no need to
> > export pci_register_host_bridge() to other kernel subsystems other than the
> > PCI compilation unit that needs it.
> >
> > Make pci_register_host_bridge() static to its compilation unit and convert
> > the existing drivers usage over to pci_scan_root_bus_bridge().
> >
> > Also, when probing the PCI host controller driver, if an error occurs, the probe
> > function code does not free memory allocated for the struct pci_host_bridge
> > resulting in memory leakage.
> >
> > This patch fixes them by using the methods that introduces by Lorenzo.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
>
> I rebased my pci/host-mediatek branch on top of pci/enumeration (which
> contains the series from Lorenzo), and folded this into the initial
> MediaTek driver commit.
>
> This branch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-mediatek&id=b6ca15d18881b784dc9efc5d81989be26ecd9fc8
>
> should have all the MediaTek bits I know about. Can you double-check
> it, please?
Sorry, that's wrong; I see your controller powerup stuff in patchwork, and
that's *not* included yet.
next prev parent reply other threads:[~2017-06-27 23:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 9:24 [RESEND PATCH] critical patch to fix pci-tree build bot failure Ryder Lee
2017-06-27 9:24 ` [PATCH] PCI: mediatek: change to use the new host bridge interface Ryder Lee
2017-06-27 22:30 ` Bjorn Helgaas
2017-06-27 23:20 ` Bjorn Helgaas [this message]
2017-06-28 1:21 ` Ryder Lee
2017-06-27 13:20 ` [RESEND PATCH] critical patch to fix pci-tree build bot failure Bjorn Helgaas
2017-06-27 22:10 ` Stephen Rothwell
2017-06-27 22:23 ` Bjorn Helgaas
2017-06-28 20:43 ` Bjorn Helgaas
2017-06-28 21:55 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627232057.GK17844@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.