All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
	qemu-devel@nongnu.org, Laurent Vivier <lvivier@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 01/10] machine: export register_compat_prop()
Date: Wed, 28 Jun 2017 14:57:58 +0800	[thread overview]
Message-ID: <20170628065758.GG14652@pxdev.xzpeter.org> (raw)
In-Reply-To: <a5b994d8-3e87-379b-65b6-f7c7e6946a80@redhat.com>

On Tue, Jun 27, 2017 at 10:05:54AM -0500, Eric Blake wrote:
> On 06/27/2017 09:55 AM, Eduardo Habkost wrote:
> 
> >> + *
> >> + * The property values set using this function must be always valid and
> >> + * never report setter errors, as they property have
> > 
> > Typo (my fault, sorry).  It should be "the property have", or "the
> > property will have".
> > 
> 
> "the property will have"

Thanks Eduardo & Eric for reviewing. I suppose this series will go
through Juan's tree if finally proper? Anyway, please anyone let me
know if we need a repost.

> 
> > With this fixed (which may be done manually by the maintainer when
> > applying):
> > 
> > Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

-- 
Peter Xu

  reply	other threads:[~2017-06-28  6:58 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  4:10 [Qemu-devel] [PATCH v6 00/10] migration: objectify MigrationState Peter Xu
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 01/10] machine: export register_compat_prop() Peter Xu
2017-06-27 14:55   ` Eduardo Habkost
2017-06-27 15:05     ` Eric Blake
2017-06-28  6:57       ` Peter Xu [this message]
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 02/10] accel: introduce AccelClass.global_props Peter Xu
2017-06-27 14:55   ` Eduardo Habkost
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 03/10] vl: clean up global property registerations Peter Xu
2017-06-27 14:56   ` Eduardo Habkost
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev Peter Xu
2017-06-27 14:47   ` Eduardo Habkost
2017-06-28  7:01     ` Peter Xu
2017-06-27 14:59   ` Eduardo Habkost
2017-06-30  2:18   ` Max Reitz
2017-06-30  3:03     ` Peter Xu
2017-06-30  7:11       ` Peter Xu
2017-06-30 12:33         ` Max Reitz
2017-06-30 13:05           ` Eric Blake
2017-06-30 13:57             ` Max Reitz
2017-07-03  1:52               ` Peter Xu
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 05/10] migration: move global_state.optional out Peter Xu
2017-06-28 18:43   ` Eduardo Habkost
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState Peter Xu
2017-06-27 11:15   ` Eric Blake
2017-06-27 13:36     ` Eduardo Habkost
2017-06-28  6:54       ` Peter Xu
2017-06-28 17:46         ` Eduardo Habkost
2017-06-28 19:13   ` Eduardo Habkost
2017-06-29  2:33     ` Peter Xu
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 07/10] migration: move skip_configuration out Peter Xu
2017-06-28 18:44   ` Eduardo Habkost
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 08/10] migration: move skip_section_footers Peter Xu
2017-06-28 18:45   ` Eduardo Habkost
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 09/10] migration: merge enforce_config_section somewhat Peter Xu
2017-06-28 19:06   ` Eduardo Habkost
2017-06-28 22:42     ` Juan Quintela
2017-06-29  3:00       ` Peter Xu
2017-06-29 19:18         ` Eduardo Habkost
2017-06-30  6:10           ` Peter Xu
2017-06-27  4:10 ` [Qemu-devel] [PATCH v6 10/10] migration: hmp: dump globals Peter Xu
2017-06-28 17:12   ` Eduardo Habkost
2017-06-30  6:22     ` Peter Xu
2017-06-28  7:15 ` [Qemu-devel] [PATCH v6 11/10] migration: add comment for TYPE_MIGRATE Peter Xu
2017-06-28  7:37   ` Juan Quintela
2017-06-28 15:37   ` Eduardo Habkost
2017-06-29  3:08     ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170628065758.GG14652@pxdev.xzpeter.org \
    --to=peterx@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.