From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 0/8] Cleanup CRTC .enable()/.disable() cargo-cult Date: Wed, 28 Jun 2017 10:20:33 +0200 Message-ID: <20170628082033.d6sykvllhzmmopm6@phenom.ffwll.local> References: <20170627203843.27004-1-laurent.pinchart+renesas@ideasonboard.com> <20170628081614.uuwx7i6rc4qvx62z@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1DFD6E50A for ; Wed, 28 Jun 2017 08:20:40 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id y5so9972418wmh.3 for ; Wed, 28 Jun 2017 01:20:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170628081614.uuwx7i6rc4qvx62z@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Neil Armstrong , Liviu Dudau , dri-devel@lists.freedesktop.org, Thierry Reding , Gerd Hoffmann , Daniel Vetter , Boris Brezillon , Thomas Hellstrom , Alexey Brodkin , Xinliang Liu , Xinwei Kong , Tomi Valkeinen , VMware Graphics , Mali DP Maintainers , Chen Feng , Jyri Sarha , Dave Airlie , Vincent Abriou , Alison Wang , Seung-Woo Kim , Philippe Cornu , Yannick Fertre List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBKdW4gMjgsIDIwMTcgYXQgMTA6MTY6MTRBTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEp1biAyNywgMjAxNyBhdCAxMTozODozNVBNICswMzAwLCBMYXVyZW50 IFBpbmNoYXJ0IHdyb3RlOgo+ID4gSGVsbG8sCj4gPiAKPiA+IFRoZSBhdG9taWMgaGVscGVycyBm YXZvdXIgdGhlIC5lbmFibGUoKSBhbmQgLmF0b21pY19kaXNhYmxlKCkgQ1JUQyBoZWxwZXIKPiA+ IG9wZXJhdGlvbnMsIGJ1dCBzdGlsbCBzdXBwb3J0IHRoZSBsZWdhY3kgLnByZXBhcmUoKSwgLmNv bW1pdCgpLCAuZGlzYWJsZSgpIGFuZAo+ID4gLmRwbXMoKSBvcGVyYXRpb25zLiBTb21lIGRyaXZl cnMgaGF2ZSBiZWVuIHVwZGF0ZWQsIGJ1dCBtb3N0IHN0aWxsIHVzZSB2YXJpb3VzCj4gPiBjb21i aW5hdGlvbiBvZiBuZXcgYW5kIGxlZ2FjeSBvcGVyYXRpb25zLCBsZWFkaW5nIHRvIGNvbmZ1c2lv biBhbW9uZyBuZXcKPiA+IGRldmVsb3BlcnMgd2hlbiB0aGV5IHJlYWQgdGhlIGNvZGUuCj4gPiAK PiA+IFRvIGF2b2lkIGNhcmdvLWN1bHQgdXNlIG9mIHRoZSBsZWdhY3kgb3BlcmF0aW9ucywgdGhp cyBwYXRjaCBzZXJpZXMKPiA+IG1hc3MtdXBkYXRlcyBhbGwgYXRvbWljIGRyaXZlcnMgdG8gdXNl IHRoZSBuZXcgQ1JUQyBhdG9taWMgaGVscGVyIG9wZXJhdGlvbnMuCj4gPiAKPiA+IEluIGFkZGl0 aW9uLCBwYXRjaCA3LzggYWRkcyBhbiBvbGQgc3RhdGUgcG9pbnRlciBhcmd1bWVudCB0byB0aGUg Q1JUQwo+ID4gLmVuYWJsZSgpIGhlbHBlciBvcGVyYXRpb24sIGFuZCByZW5hbWUgaXQgdG8gLmF0 b21pY19lbmFibGUoKSBmb3IgY29uc2lzdGVuY3kKPiA+IHdpdGggLmF0b21pY19kaXNhYmxlKCku IFRoZXNlIHR3byBjaGFuZ2VzIGNvdWxkIGhhdmUgYmVlbiBzcGxpdCBpbiBzZXBhcmF0ZQo+ID4g cGF0Y2gsIGJ1dCBhcyB0aGV5IGFyZSBzaW1wbGUgYW5kIHRvdWNoIHRoZSBzYW1lIGxhcmdlIG51 bWJlciBvZiBmaWxlcywKPiA+IGtlZXBpbmcgdGhlIHR3byBjaGFuZ2VzIGFzIG9uZSBpcyBzaW1w bGVyIGFuZCBsZXNzIGVycm9yLXByb25lLgo+ID4gCj4gPiBUaGUgcGF0Y2hlcyBhcmUgYmFzZWQg b24gdG9wIG9mIHRoZSBkcm0tbWlzYy1uZXh0IGJyYW5jaCBhbmQgaGF2ZSBiZWVuCj4gPiBjb21w aWxlLXRlc3RlZCBvbmx5IGV4Y2VwdCBmb3IgcmNhci1kdS1kcm0gdGhhdCBoYXMgYmVlbiB0ZXN0 ZWQgb24gcmVhbAo+ID4gaGFyZHdhcmUuIEdpdmVuIHRoZSBoaWdoIHJpc2sgb2YgY29uZmxpY3Rz IEkgd291bGQgbGlrZSB0byBnZXQgdGhlbSBtZXJnZWQgYXMKPiA+IHNvb24gYXMgcG9zc2libGUg KGFmdGVyLCBvZiBjb3Vyc2UsIHByb3BlciByZXZpZXcgYW5kIHRlc3RpbmcpLgo+IAo+IE1ha2Vz IHNlbnNlLCBzbyBJIHdlbnQgYWhlYWQgYW5kIHB1bGxlZCBpbiBwYXRjaGVzIDEtNi4gSSB0aGlu ayA3JjggbmVlZCBhCj4gYml0IG1vcmUgc29ha2luZyB0byBnYXRoZXIgYWNrcywgaWYgb25seSBm b3IgYXdlYXJlbmVzcy4gUGx1cyBhIGJpdCBtb3JlCj4ga2VybmVsLWRvYyBwb2xpc2ggaW1vLgoK T24gdGhlIGtlcm5lbC1kb2MgcG9saXNoOiBHcmVwcGluZyBmb3IgZHJtX2NydGNfaGVscGVyX2Z1 bmNzXC5lbmFibGUgYW5kClwuZGlzYWJsZSBicm91Z2h0IHVwIGEgZmV3IHJlZmVyZW5jZXMgdGhh dCBuZWVkIHRvIGJlIHVwZGF0ZWQgaW4geW91cgpwYXRjaGVzIDcmOC4KLURhbmllbAoKPiAtRGFu aWVsCj4gCj4gPiAKPiA+IExhdXJlbnQgUGluY2hhcnQgKDgpOgo+ID4gICBkcm06IGFyY3BndTog UmVtb3ZlIENSVEMgLmNvbW1pdCgpIGhlbHBlciBvcGVyYXRpb24KPiA+ICAgZHJtOiBhcmNwZ3U6 IFJlbW92ZSBDUlRDIC5wcmVwYXJlKCkgaGVscGVyIG9wZXJhdGlvbgo+ID4gICBkcm06IHF4bDog UmVtb3ZlIHVudXNlZCBDUlRDIC5kcG1zKCkgaGVscGVyIG9wZXJhdGlvbgo+ID4gICBkcm06IHF4 bDogUmVwbGFjZSBDUlRDIC5jb21taXQoKSBoZWxwZXIgb3BlcmF0aW9uIHdpdGggLmVuYWJsZSgp Cj4gPiAgIGRybTogdm13Z2Z4OiBSZW1vdmUgdW5uZWVkZWQgQ1JUQyAucHJlcGFyZSgpIGhlbHBl ciBvcGVyYXRpb24KPiA+ICAgZHJtOiB2bXdnZng6IFJlcGxhY2UgQ1JUQyAuY29tbWl0KCkgaGVs cGVyIG9wZXJhdGlvbiB3aXRoIC5lbmFibGUoKQo+ID4gICBkcm06IEFkZCBvbGQgc3RhdGUgcG9p bnRlciB0byBDUlRDIC5lbmFibGUoKSBoZWxwZXIgZnVuY3Rpb24KPiA+ICAgZHJtOiBDb252ZXJ0 IGF0b21pYyBkcml2ZXJzIGZyb20gQ1JUQyAuZGlzYWJsZSgpIHRvIC5hdG9taWNfZGlzYWJsZSgp Cj4gPiAKPiA+ICBkcml2ZXJzL2dwdS9kcm0vYXJjL2FyY3BndV9jcnRjLmMgICAgICAgICAgICAg ICB8IDEyICsrKystLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2FybS9oZGxjZF9jcnRjLmMgICAg ICAgICAgICAgICAgfCAxMCArKysrLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBf Y3J0Yy5jICAgICAgICAgICAgICAgfCAxMCArKysrLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2F0 bWVsLWhsY2RjL2F0bWVsX2hsY2RjX2NydGMuYyAgfCAxMCArKysrLS0tCj4gPiAgZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgICAgICAgICAgICAgfCAgNyArKystLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuYyAgICAgICAgIHwgMTAgKysrKy0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9jcnRjLmMgICAgICAgIHwg MTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9mc2wtZGN1L2ZzbF9kY3VfZHJtX2NydGMu YyAgICAgIHwgIDUgKystLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24vaGlibWMvaGli bWNfZHJtX2RlLmMgIHwgMTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9oaXNpbGljb24v a2lyaW4va2lyaW5fZHJtX2FkZS5jIHwgMTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9p bXgvaXB1djMtY3J0Yy5jICAgICAgICAgICAgICAgIHwgIDUgKystLQo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9jcnRjLmMgICAgICAgICAgICAgIHwgMTAgKysrKy0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDQvbWRwNF9jcnRjLmMgICAgICAgIHwg MTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbWRwL21kcDUvbWRwNV9jcnRjLmMg ICAgICAgIHwgMTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfY3J0 Yy5jICAgICAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9xeGwvcXhs X2Rpc3BsYXkuYyAgICAgICAgICAgICAgIHwgMTUgKysrKy0tLS0tLQo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5jICAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4gIGRy aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMgICAgIHwgMTAgKysrKy0t LQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdGkvc3RpX2NydGMuYyAgICAgICAgICAgICAgICAgIHwg MTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdG0vbHRkYy5jICAgICAgICAgICAgICAg ICAgICAgIHwgMTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9jcnRj LmMgICAgICAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS90ZWdyYS9k Yy5jICAgICAgICAgICAgICAgICAgICAgIHwgMTAgKysrKy0tLQo+ID4gIGRyaXZlcnMvZ3B1L2Ry bS90aWxjZGMvdGlsY2RjX2NydGMuYyAgICAgICAgICAgIHwgMTYgKysrKysrKysrLS0KPiA+ICBk cml2ZXJzL2dwdS9kcm0vdmM0L3ZjNF9jcnRjLmMgICAgICAgICAgICAgICAgICB8IDEwICsrKyst LS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vdmlydGlvL3ZpcnRncHVfZGlzcGxheS5jICAgICAgICB8 IDEwICsrKystLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dmeF9sZHUuYyAgICAg ICAgICAgICB8IDI3ICsrKysrKy0tLS0tLS0tLS0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS92bXdn Zngvdm13Z2Z4X3Njcm4uYyAgICAgICAgICAgIHwgMTQgKysrKystLS0tCj4gPiAgZHJpdmVycy9n cHUvZHJtL3Ztd2dmeC92bXdnZnhfc3RkdS5jICAgICAgICAgICAgfCAxMCArKysrLS0tCj4gPiAg ZHJpdmVycy9ncHUvZHJtL3p0ZS96eF92b3UuYyAgICAgICAgICAgICAgICAgICAgfCAxMCArKysr LS0tCj4gPiAgaW5jbHVkZS9kcm0vZHJtX21vZGVzZXRfaGVscGVyX3Z0YWJsZXMuaCAgICAgICAg fCAzOCArKysrKysrKysrKysrLS0tLS0tLS0tLS0tCj4gPiAgMzEgZmlsZXMgY2hhbmdlZCwgMjA0 IGluc2VydGlvbnMoKyksIDE1NSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gLS0gCj4gPiBSZWdhcmRz LAo+ID4gCj4gPiBMYXVyZW50IFBpbmNoYXJ0Cj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4g PiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo+IAo+IC0tIAo+IERhbmllbCBW ZXR0ZXIKPiBTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KPiBodHRwOi8vYmxv Zy5mZndsbC5jaAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENv cnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=