From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751896AbdF1Mo6 (ORCPT ); Wed, 28 Jun 2017 08:44:58 -0400 Received: from 8bytes.org ([81.169.241.247]:48842 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbdF1Mov (ORCPT ); Wed, 28 Jun 2017 08:44:51 -0400 Date: Wed, 28 Jun 2017 14:44:48 +0200 From: Joerg Roedel To: Suravee Suthikulpanit Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Joerg Roedel Subject: Re: [PATCH v2] iommu/amd: Fix interrupt remapping when disable guest_mode Message-ID: <20170628124447.GA28603@8bytes.org> References: <1498469284-85652-1-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1498469284-85652-1-git-send-email-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2017 at 04:28:04AM -0500, Suravee Suthikulpanit wrote: > Pass-through devices to VM guest can get updated IRQ affinity > information via irq_set_affinity() when not running in guest mode. > Currently, AMD IOMMU driver in GA mode ignores the updated information > if the pass-through device is setup to use vAPIC regardless of guest_mode. > This could cause invalid interrupt remapping. > > Also, the guest_mode bit should be set and cleared only when > SVM updates posted-interrupt interrupt remapping information. > > Signed-off-by: Suravee Suthikulpanit > Cc: Joerg Roedel Nervermind, I added this fixes line and applied the patch: Fixes: d98de49a53e48 ('iommu/amd: Enable vAPIC interrupt remapping mode by default'