From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751689AbdF1NEt (ORCPT ); Wed, 28 Jun 2017 09:04:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:43082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751535AbdF1NEm (ORCPT ); Wed, 28 Jun 2017 09:04:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0761E22B5A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Wed, 28 Jun 2017 10:04:38 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 25/37] perf script: Add synthesized Intel PT power and ptwrite events Message-ID: <20170628130438.GB3342@kernel.org> References: <1495786658-18063-1-git-send-email-adrian.hunter@intel.com> <1495786658-18063-26-git-send-email-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1495786658-18063-26-git-send-email-adrian.hunter@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, May 26, 2017 at 11:17:26AM +0300, Adrian Hunter escreveu: > Add definitions for synthesized Intel PT events for power and ptwrite. > +++ b/tools/perf/util/event.h > +/* > + * Raw data formats for synthesized events. Note that raw data plus the raw data > + * size (4 bytes) must align to 8-bytes. > + */ > + > +struct perf_synth_intel_ptwrite { > + union { > + struct { > + u32 ip : 1, > + reserved : 31; > + }; > + u32 flags; > + }; > + u64 payload; > +} __packed; some versions of clang and gcc dislike this __packed here: In file included from builtin-script.c:5: In file included from /git/linux/tools/perf/util/debug.h:8: /git/linux/tools/perf/util/event.h:274:2: error: packed attribute is unnecessary for (null) [-Werror,-Wpacked] union { ^ /git/linux/tools/perf/util/event.h:285:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked] u32 reserved; ^ /git/linux/tools/perf/util/event.h:298:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked] u32 reserved; ^ /git/linux/tools/perf/util/event.h:322:6: error: packed attribute is unnecessary for 'reserved' [-Werror,-Wpacked] u32 reserved; ^ 4 errors generated. mv: can't rename '/tmp/build/perf/.builtin-script.o.tmp': No such file or directory /git/linux/tools/build/Makefile.build:101: recipe for target '/tmp/build/perf/builtin-script.o' failed Failing in various distros: [root@jouet ~]# waitp 3940 ; time dm 1 92.3684147260 alpine:3.4: FAIL 2 95.9136365930 alpine:3.5: FAIL 3 104.8328303770 alpine:3.6: FAIL 4 121.6584964930 alpine:edge: FAIL 5 37.2536373490 android-ndk:r12b-arm: Ok 6 83.9077612370 archlinux:latest: Ok 7 14.7094639200 centos:5: FAIL 8 16.6371634320 centos:6: FAIL Investigating... > + > +struct perf_synth_intel_mwait { > + u32 reserved; > + union { > + struct { > + u64 hints : 8, > + reserved1 : 24, > + extensions : 2, > + reserved2 : 30; > + }; > + u64 payload; > + }; > +} __packed; > + > +struct perf_synth_intel_pwre { > + u32 reserved; > + union { > + struct { > + u64 reserved1 : 7, > + hw : 1, > + subcstate : 4, > + cstate : 4, > + reserved2 : 48; > + }; > + u64 payload; > + }; > +} __packed; > + > +struct perf_synth_intel_exstop { > + union { > + struct { > + u32 ip : 1, > + reserved : 31; > + }; > + u32 flags; > + }; > +}; > + > +struct perf_synth_intel_pwrx { > + u32 reserved; > + union { > + struct { > + u64 deepest_cstate : 4, > + last_cstate : 4, > + wake_reason : 4, > + reserved1 : 52; > + }; > + u64 payload; > + }; > +} __packed; > + > +struct perf_synth_intel_cbr { > + union { > + struct { > + u32 cbr : 8, > + reserved1 : 8, > + max_nonturbo : 8, > + reserved2 : 8; > + }; > + u32 flags; > + }; > + u32 freq; > + u32 reserved3; > +}; > + > /* > * The kernel collects the number of events it couldn't send in a stretch and > * when possible sends this number in a PERF_RECORD_LOST event. The number of > -- > 1.9.1