Re: [PATCH] RDMA/core: Add wait/retry version of ibnl_unicast

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]

On Wed, Jun 28, 2017 at 09:12:11AM -0500, Chien Tin Tung wrote:
> On Wed, Jun 28, 2017 at 09:02:45AM -0500, Mustafa Ismail wrote:
> > Add a wait/retry version of ibnl_unicast, ibnl_unicast_wait,
> > and modify ibnl_unicast to not wait/retry.  This eliminates
> > the undesirable wait for future users of ibnl_unicast.
> >
> > Change Portmapper calls originating from kernel to user-space
> > to use ibnl_unicast_wait and take advantage of the wait/retry
> > logic in netlink_unicast.
> >
> > Signed-off-by: Mustafa Ismail <mustafa.ismail-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Chien Tin Tung <chien.tin.tung-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> >  drivers/infiniband/core/iwpm_msg.c |  6 +++---
> >  drivers/infiniband/core/netlink.c  | 12 +++++++++++-
> >  include/rdma/rdma_netlink.h        | 10 ++++++++++
> >  3 files changed, 24 insertions(+), 4 deletions(-)
>
> Please apply this patch instead of Leon's patch to revert
> "IB/core: Add flow control to the portmapper netlink calls".
>
> Leon, we can work out names and parameters if this works for you.

Chien,

The names are less my worries with this patch. First of all, it misleads
by using wait/retry naming, because it blocks and not waits. The second,
I disagree with solution in kernel for user space application which can't
handle the netlink errors. Can you please explain why the kernel fix is
unavoidable and the bug in the user space application is not needed to
be fixed?

Thanks

>
> Chien

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]