Re: [PATCH 08/17 v5] xen/arm: vpl011: Add a new domctl API to initialize vpl011

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Jun 22, 2017 at 01:08:43PM +0530, Bhupinder Thakur wrote:
[...]
> +#if defined (__arm__) || defined(__aarch64__)
> +/**
> + * This function initializes the vpl011 emulation and returns
> + * the event to be used by the backend for communicating with
> + * the emulation code.
> + *
> + * @parm xch a handle to an open hypervisor interface
> + * @parm domid the domain to get information from
> + * @parm console_domid the domid of the backend console
> + * @parm gfn the guest pfn to be used as the ring buffer
> + * @parm evtchn the event channel to be used for events
> + * @return 0 on success, negative error on failure
> + */
> +int xc_dom_vpl011_init(xc_interface *xch,
> +                       uint32_t domid,
> +                       uint32_t console_domid,

Use domid_t please.

> +                       xen_pfn_t gfn,
> +                       evtchn_port_t *evtchn);
> +#endif
> +
[...]
>  }
>  
> +int libxl__arch_build_dom_finish(libxl__gc *gc,
> +                                 libxl_domain_build_info *info,
> +                                 struct xc_dom_image *dom,
> +                                 libxl__domain_build_state *state)
> +{
> +    int ret = 0;
> +
> +    if ( info->arch_arm.vuart ) {

Coding style issues here and in a lot of other places in libxl.

> +        ret = xc_dom_vpl011_init(CTX->xch,
> +                                 dom->guest_domid,
> +                                 dom->console_domid,
> +                                 dom->vuart_gfn,
> +                                 &state->vuart_port);
> +        if ( ret < 0 )
> +        {
> +            LOG(ERROR, "xc_dom_vpl011_init failed\n");
> +        }

It is just one line so you can omit {}.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel