From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbdF1T13 (ORCPT ); Wed, 28 Jun 2017 15:27:29 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51376 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752364AbdF1T1N (ORCPT ); Wed, 28 Jun 2017 15:27:13 -0400 Date: Wed, 28 Jun 2017 19:45:07 +0100 From: Mark Brown To: Aravind Thokala Cc: Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk> References: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k42cjlrrmxvh7iio" Content-Disposition: inline In-Reply-To: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com> X-Cookie: 667: User-Agent: NeoMutt/20170609 (1.8.3) X-SA-Exim-Connect-IP: 176.12.107.140 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --k42cjlrrmxvh7iio Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote: > This patch fixes the checkpatch.pl warnings on the driver > file. This isn't a good changelog, what are the warnings and why are we fixing them? The fact that checkpatch complains isn't meaningful in and of itself - it's OK to say that checkpatch helped identify issues but it's not perfect and we need to understand what is being changed and why. --k42cjlrrmxvh7iio Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAllT+TMACgkQJNaLcl1U h9DhMgf9FFjJVZ51W+Rv7zcVMA/0clNSR0dEo0Z3UJRaWeCQWeqlSzeZAGoJRNuJ nAsYuQBocLGOWZO+WlN1MOaFHeNFBiLELxBCsH3Eaz580tb3nWL6LnxYOpxmTuM0 s4nqch0vp5oPLb2kwvSWvP7Fmz3MyptniqyqAEcK4iGtYnYtH8ay4QYiWGRxsxfp ij4AstREKXLxSYNhThilLNbGkvte5YX1+no17+OG3AjDC2mYRXhUDYVQd8mN69Y2 llCicGsh04WlSZzVHaFrvSBCushodXXCWHJ086mOhaHQfUVS2mFbfoH4f9bdK9++ GsHle0uFdr1XekIBEAxi7omnr8sqUA== =ySDW -----END PGP SIGNATURE----- --k42cjlrrmxvh7iio-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings Date: Wed, 28 Jun 2017 19:45:07 +0100 Message-ID: <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk> References: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k42cjlrrmxvh7iio" Cc: Florian Fainelli , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Aravind Thokala Return-path: Content-Disposition: inline In-Reply-To: <1498579630-10109-1-git-send-email-aravind.thk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-spi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: --k42cjlrrmxvh7iio Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote: > This patch fixes the checkpatch.pl warnings on the driver > file. This isn't a good changelog, what are the warnings and why are we fixing them? The fact that checkpatch complains isn't meaningful in and of itself - it's OK to say that checkpatch helped identify issues but it's not perfect and we need to understand what is being changed and why. --k42cjlrrmxvh7iio Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAllT+TMACgkQJNaLcl1U h9DhMgf9FFjJVZ51W+Rv7zcVMA/0clNSR0dEo0Z3UJRaWeCQWeqlSzeZAGoJRNuJ nAsYuQBocLGOWZO+WlN1MOaFHeNFBiLELxBCsH3Eaz580tb3nWL6LnxYOpxmTuM0 s4nqch0vp5oPLb2kwvSWvP7Fmz3MyptniqyqAEcK4iGtYnYtH8ay4QYiWGRxsxfp ij4AstREKXLxSYNhThilLNbGkvte5YX1+no17+OG3AjDC2mYRXhUDYVQd8mN69Y2 llCicGsh04WlSZzVHaFrvSBCushodXXCWHJ086mOhaHQfUVS2mFbfoH4f9bdK9++ GsHle0uFdr1XekIBEAxi7omnr8sqUA== =ySDW -----END PGP SIGNATURE----- --k42cjlrrmxvh7iio-- -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: broonie@kernel.org (Mark Brown) Date: Wed, 28 Jun 2017 19:45:07 +0100 Subject: [PATCH] spi/bcm63xx-hspi: Fix checkpatch warnings In-Reply-To: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com> References: <1498579630-10109-1-git-send-email-aravind.thk@gmail.com> Message-ID: <20170628184507.tnl7jc4wvtt5op5q@sirena.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 27, 2017 at 09:37:10PM +0530, Aravind Thokala wrote: > This patch fixes the checkpatch.pl warnings on the driver > file. This isn't a good changelog, what are the warnings and why are we fixing them? The fact that checkpatch complains isn't meaningful in and of itself - it's OK to say that checkpatch helped identify issues but it's not perfect and we need to understand what is being changed and why. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: