From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751695AbdF1UaG (ORCPT ); Wed, 28 Jun 2017 16:30:06 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33059 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbdF1UaC (ORCPT ); Wed, 28 Jun 2017 16:30:02 -0400 Date: Wed, 28 Jun 2017 21:29:58 +0100 From: Okash Khawaja To: Colin King Cc: William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Greg Kroah-Hartman , Andy Shevchenko , Alexandre Ghiti , Dan Carpenter , Rui Teng , speakup@linux-speakup.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: speakup: make function ser_to_dev static Message-ID: <20170628202958.GA4220@sanghar> References: <20170628131351.22106-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170628131351.22106-1-colin.king@canonical.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jun 28, 2017 at 02:13:51PM +0100, Colin King wrote: > From: Colin Ian King > > The helper function ser_to_dev does not need to be in global scope, so > make it static. > > Cleans up sparse warning: > "warning: symbol 'ser_to_dev' was not declared. Should it be static?" Thanks very much! > > Signed-off-by: Colin Ian King Reviewed-by: Okash Khawaja > --- > drivers/staging/speakup/spk_ttyio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c > index 442f191a017e..ed8e96b06ead 100644 > --- a/drivers/staging/speakup/spk_ttyio.c > +++ b/drivers/staging/speakup/spk_ttyio.c > @@ -21,7 +21,7 @@ struct spk_ldisc_data { > static struct spk_synth *spk_ttyio_synth; > static struct tty_struct *speakup_tty; > > -int ser_to_dev(int ser, dev_t *dev_no) > +static int ser_to_dev(int ser, dev_t *dev_no) > { > if (ser < 0 || ser > (255 - 64)) { > pr_err("speakup: Invalid ser param. Must be between 0 and 191 inclusive.\n"); > -- > 2.11.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Okash Khawaja Date: Wed, 28 Jun 2017 20:29:58 +0000 Subject: Re: [PATCH] staging: speakup: make function ser_to_dev static Message-Id: <20170628202958.GA4220@sanghar> List-Id: References: <20170628131351.22106-1-colin.king@canonical.com> In-Reply-To: <20170628131351.22106-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Greg Kroah-Hartman , Andy Shevchenko , Alexandre Ghiti , Dan Carpenter , Rui Teng , speakup@linux-speakup.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Hi, On Wed, Jun 28, 2017 at 02:13:51PM +0100, Colin King wrote: > From: Colin Ian King > > The helper function ser_to_dev does not need to be in global scope, so > make it static. > > Cleans up sparse warning: > "warning: symbol 'ser_to_dev' was not declared. Should it be static?" Thanks very much! > > Signed-off-by: Colin Ian King Reviewed-by: Okash Khawaja > --- > drivers/staging/speakup/spk_ttyio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/spk_ttyio.c b/drivers/staging/speakup/spk_ttyio.c > index 442f191a017e..ed8e96b06ead 100644 > --- a/drivers/staging/speakup/spk_ttyio.c > +++ b/drivers/staging/speakup/spk_ttyio.c > @@ -21,7 +21,7 @@ struct spk_ldisc_data { > static struct spk_synth *spk_ttyio_synth; > static struct tty_struct *speakup_tty; > > -int ser_to_dev(int ser, dev_t *dev_no) > +static int ser_to_dev(int ser, dev_t *dev_no) > { > if (ser < 0 || ser > (255 - 64)) { > pr_err("speakup: Invalid ser param. Must be between 0 and 191 inclusive.\n"); > -- > 2.11.0 >