From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: linux-net-drivers@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] sfc: fix attempt to translate invalid filter ID
Date: Thu, 29 Jun 2017 16:02:45 -0400 (EDT) [thread overview]
Message-ID: <20170629.160245.963659993885114524.davem@davemloft.net> (raw)
In-Reply-To: <ac506723-66ef-0945-ff1e-c0132f0c71c0@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Thu, 29 Jun 2017 16:50:06 +0100
> When filter insertion fails with no rollback, we were trying to convert
> EFX_EF10_FILTER_ID_INVALID to an id to store in 'ids' (which is either
> vlan->uc or vlan->mc). This would WARN_ON_ONCE and then record a bogus
> filter ID of 0x1fff, neither of which is a good thing.
>
> Fixes: 0ccb998bf46d ("sfc: fix filter_id misinterpretation in edge case")
> Signed-off-by: Edward Cree <ecree@solarflare.com>
Applied, thanks.
prev parent reply other threads:[~2017-06-29 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 15:50 [PATCH net] sfc: fix attempt to translate invalid filter ID Edward Cree
2017-06-29 20:02 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629.160245.963659993885114524.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.