From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 2/2] drm/msm: gpu: call qcom_mdt interfaces only for ARCH_QCOM Date: Wed, 28 Jun 2017 22:11:50 -0700 Message-ID: <20170629051150.GY18666@tuxbook> References: <20170620201720.225593-1-arnd@arndb.de> <20170620201720.225593-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170620201720.225593-2-arnd-r2nGTMty4D4@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Arnd Bergmann Cc: Archit Taneja , David Airlie , Daniel Vetter , Jordan Crouse , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sushmita Susheelendra , Eric Anholt , Rob Clark , Srinivas Kandagatla , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: linux-arm-msm@vger.kernel.org T24gVHVlIDIwIEp1biAxMzoxNiBQRFQgMjAxNywgQXJuZCBCZXJnbWFubiB3cm90ZToKCj4gV2hl biBjb21waWxlLXRlc3RpbmcgZm9yIHNvbWV0aGluZyBvdGhlciB0aGFuIEFSQ0hfUUNPTSwKPiB3 ZSBydW4gaW50byBhIGxpbmsgZXJyb3I6Cj4gCj4gZHJpdmVycy9ncHUvZHJtL21zbS9hZHJlbm8v YTV4eF9ncHUubzogSW4gZnVuY3Rpb24gYGE1eHhfaHdfaW5pdCc6Cj4gYTV4eF9ncHUuYzooLnRl eHQuYTV4eF9od19pbml0KzB4NjAwKTogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgcWNvbV9tZHRf Z2V0X3NpemUnCj4gYTV4eF9ncHUuYzooLnRleHQuYTV4eF9od19pbml0KzB4OTNjKTogdW5kZWZp bmVkIHJlZmVyZW5jZSB0byBgcWNvbV9tZHRfbG9hZCcKPiAKPiBUaGVyZSBpcyBhbHJlYWR5IGFu ICNpZmRlZiB0aGF0IHRyaWVzIHRvIGNoZWNrIGZvciBDT05GSUdfUUNPTV9NRFRfTE9BREVSLAo+ IGJ1dCB0aGF0IHN5bWJvbCBpcyBvbmx5IG1lYW5pbmdmdWwgd2hlbiBidWlsZGluZyBmb3IgQVJD SF9RQ09NLgo+IAo+IFRoaXMgYWRkcyBhIGNvbXBpbGUtdGltZSBjaGVjayBmb3IgQVJDSF9RQ09N LCBhbmQgY2xhcmlmaWVzIHRoZQo+IEtjb25maWcgc2VsZWN0IHN0YXRlbWVudCBzbyB3ZSBkb24n dCBldmVuIHRyeSBpdCBmb3Igb3RoZXIgdGFyZ2V0cy4KPiAKPiBUaGUgY2hlY2sgZm9yIENPTkZJ R19RQ09NX01EVF9MT0FERVIgY2FuIHRoZW4gZ28gYXdheSwgd2hpY2ggYWxzbwo+IGltcHJvdmVz IGNvbXBpbGUtdGltZSBjb3ZlcmFnZSBhbmQgbWFrZXMgdGhlIGNvZGUgYSBsaXR0bGUgbmljZXIK PiB0byByZWFkLgoKQWNrZWQtYnk6IEJqb3JuIEFuZGVyc3NvbiA8Ympvcm4uYW5kZXJzc29uQGxp bmFyby5vcmc+CgpSZWdhcmRzLApCam9ybgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9mcmVlZHJlbm8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbdF2FMK (ORCPT ); Thu, 29 Jun 2017 01:12:10 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:35738 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751784AbdF2FMC (ORCPT ); Thu, 29 Jun 2017 01:12:02 -0400 Date: Wed, 28 Jun 2017 22:11:50 -0700 From: Bjorn Andersson To: Arnd Bergmann Cc: Rob Clark , Jordan Crouse , David Airlie , Srinivas Kandagatla , Daniel Vetter , Archit Taneja , Eric Anholt , Sushmita Susheelendra , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drm/msm: gpu: call qcom_mdt interfaces only for ARCH_QCOM Message-ID: <20170629051150.GY18666@tuxbook> References: <20170620201720.225593-1-arnd@arndb.de> <20170620201720.225593-2-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170620201720.225593-2-arnd@arndb.de> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 20 Jun 13:16 PDT 2017, Arnd Bergmann wrote: > When compile-testing for something other than ARCH_QCOM, > we run into a link error: > > drivers/gpu/drm/msm/adreno/a5xx_gpu.o: In function `a5xx_hw_init': > a5xx_gpu.c:(.text.a5xx_hw_init+0x600): undefined reference to `qcom_mdt_get_size' > a5xx_gpu.c:(.text.a5xx_hw_init+0x93c): undefined reference to `qcom_mdt_load' > > There is already an #ifdef that tries to check for CONFIG_QCOM_MDT_LOADER, > but that symbol is only meaningful when building for ARCH_QCOM. > > This adds a compile-time check for ARCH_QCOM, and clarifies the > Kconfig select statement so we don't even try it for other targets. > > The check for CONFIG_QCOM_MDT_LOADER can then go away, which also > improves compile-time coverage and makes the code a little nicer > to read. Acked-by: Bjorn Andersson Regards, Bjorn