Re: [PATCH 4/5] ASoC: Intel: bxtn: Assign sram address to sst structure

[Vinod Koul <vinod.koul@intel.com>]

On Thu, Jun 29, 2017 at 08:34:07AM +0530, Guneshwor Singh wrote:
> To read dsp registers via debugfs, assign sram address
> in dsp_init().
> 
> Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>
> ---
>  sound/soc/intel/skylake/bxt-sst.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c
> index f5e7dbb1ba39..cf11b84888b9 100644
> --- a/sound/soc/intel/skylake/bxt-sst.c
> +++ b/sound/soc/intel/skylake/bxt-sst.c
> @@ -573,6 +573,10 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq,
>  	sst->fw_ops = bxt_fw_ops;
>  	sst->addr.lpe = mmio_base;
>  	sst->addr.shim = mmio_base;
> +	sst->addr.sram0_base = BXT_ADSP_SRAM0_BASE;
> +	sst->addr.sram1_base = BXT_ADSP_SRAM1_BASE;
> +	sst->addr.w0_stat_sz = SKL_ADSP_W0_STAT_SZ;
> +	sst->addr.w0_up_sz = SKL_ADSP_W0_UP_SZ;

I think you need to modfiy the order and this and following change. With
last patch applied and this not present, you would break if someone tries to
read debugfs file as these adresses are NULL, so add these values first and
then the usage :)

>  
>  	sst_dsp_mailbox_init(sst, (BXT_ADSP_SRAM0_BASE + SKL_ADSP_W0_STAT_SZ),
>  			SKL_ADSP_W0_UP_SZ, BXT_ADSP_SRAM1_BASE, SKL_ADSP_W1_SZ);
> -- 
> 2.13.0
> 

-- 
~Vinod