From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752355AbdF2HbO (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Jun 2017 03:31:14 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:35276 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751878AbdF2HbG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Jun 2017 03:31:06 -0400
Date: Thu, 29 Jun 2017 09:31:02 +0200
From: Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: Pavel Machek <pavel@ucw.cz>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: Spurious touchpad events with closed LID
Message-ID: <20170629073102.GG25196@pali>
References: <201706261854.53970@pali>
 <20170626170312.GB4965@dtor-ws>
 <201706262109.42628@pali>
 <20170628201530.GB18101@amd>
 <1498689867.6564.6.camel@hadess.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1498689867.6564.6.camel@hadess.net>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thursday 29 June 2017 00:44:27 Bastien Nocera wrote:
> On Wed, 2017-06-28 at 22:15 +0200, Pavel Machek wrote:
> > 
> <snip>
> > While policy normally belongs to userspace, I'd argue this is
> > workaround for a hardware bug, and in-kernel solution would be
> > acceptable.
> > 
> > Anyway, disable attribute would be nice first step.
> 
> It's already fixed for those of us on recent distributions. The
> "ID_INPUT_TOUCHPAD_INTEGRATION=internal" touchpads will be disabled
> when the lid is closed, when libinput is used to process the events.

But this does not fix other usage of /dev/input/* and also does not fix
pressing spurious keys in linux virtual tty (ctrl+alt+f1). So it is not
a fix.

Also important question is: How you detect which input device is
"internal", non-removable part of notebook and which one is external?

You can have external USB touchpad, and also you can have external PS/2
keyboard connected to docking station (which was e.g. my situation).

Also there are PS/2 to active USB converters, to make whole situation
complicated.

And moreover some internal notebook keyboards are connected via USB and
some touchpads via i2c/smbus.

I think this detection is not easy or at least I have no idea how to do
properly. Existence of PS/2 keyboard does not mean it is internal and
existence of USB keyboard does not mean it is external.

Maybe ACPI/DSDT provides some information? (No idea, just asking)

> Usually, non-crappy hardware will do that in firmware, but software is
> easier to patch ;)

-- 
Pali Rohár
pali.rohar@gmail.com