All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace-listen: add missing header
Date: Thu, 29 Jun 2017 08:19:56 -0400	[thread overview]
Message-ID: <20170629081956.08115a70@gandalf.local.home> (raw)
In-Reply-To: <c68c868b573acc73e144312326750be2ed96632f.1498736781.git.baruch@tkos.co.il>

On Thu, 29 Jun 2017 14:46:21 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> The PATH_MAX macro requires the limits.h header. This fixes build with musl
> libc:
> 
> .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
>   snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
>                 ^~~~~~~~

Thanks! I have a few other patches that need to go into trace-cmd. I'll
try to get to that today or tomorrow.

-- Steve

> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  trace-listen.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/trace-listen.c b/trace-listen.c
> index 17ff9d8c160c..838d6bcf3649 100644
> --- a/trace-listen.c
> +++ b/trace-listen.c
> @@ -31,6 +31,7 @@
>  #include <fcntl.h>
>  #include <signal.h>
>  #include <errno.h>
> +#include <limits.h>
>  
>  #include "trace-local.h"
>  #include "trace-msg.h"

  reply	other threads:[~2017-06-29 12:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-29 11:46 [PATCH] trace-listen: add missing header Baruch Siach
2017-06-29 12:19 ` Steven Rostedt [this message]
2017-06-29 12:29   ` Baruch Siach
2017-06-29 12:57     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629081956.08115a70@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=baruch@tkos.co.il \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.