From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753048AbdF2M5b convert rfc822-to-8bit (ORCPT ); Thu, 29 Jun 2017 08:57:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:58510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752894AbdF2M5Z (ORCPT ); Thu, 29 Jun 2017 08:57:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABFCB22B60 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Thu, 29 Jun 2017 08:57:21 -0400 From: Steven Rostedt To: Baruch Siach Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] trace-listen: add missing header Message-ID: <20170629085721.32d65554@gandalf.local.home> In-Reply-To: <20170629122939.wvt632hf6tnuesf4@tarshish> References: <20170629081956.08115a70@gandalf.local.home> <20170629122939.wvt632hf6tnuesf4@tarshish> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jun 2017 15:29:39 +0300 Baruch Siach wrote: > Hi Steven, > > On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote: > > On Thu, 29 Jun 2017 14:46:21 +0300 > > Baruch Siach wrote: > > > > > The PATH_MAX macro requires the limits.h header. This fixes build with musl > > > libc: > > > > > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’: > > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function) > > > snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid"); > > > ^~~~~~~~ > > > > Thanks! I have a few other patches that need to go into trace-cmd. I'll > > try to get to that today or tomorrow. > > There is no rush. > > By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the > same file might bite at some point. Also, MAX_PATH has different values in > different files. Yeah, that code should be cleaned up. It was probably me rushing to get some feature in and not spending the time to do it nicely. Feel free to send more patches ;-) -- Steve