From: Fam Zheng <famz@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, alistair23@gmail.com,
edgar.iglesias@xilinx.com, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [RFC v1 3/4] util/oslib-win32: Fix up if conditional
Date: Thu, 29 Jun 2017 17:34:09 +0800 [thread overview]
Message-ID: <20170629093409.GE28654@lemon.lan> (raw)
In-Reply-To: <2c339ec0264c85f9c8a4884ffb8ebe059b3b9e4b.1498607452.git.alistair.francis@xilinx.com>
On Tue, 06/27 16:57, Alistair Francis wrote:
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Acked-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
> ---
>
> util/oslib-win32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/oslib-win32.c b/util/oslib-win32.c
> index 7ec0f8e083..a015e1ac96 100644
> --- a/util/oslib-win32.c
> +++ b/util/oslib-win32.c
> @@ -438,7 +438,7 @@ static int poll_rest(gboolean poll_msgs, HANDLE *handles, gint nhandles,
> if (timeout == 0 && nhandles > 1) {
> /* Remove the handle that fired */
> int i;
> - if (ready < nhandles - 1) {
> + if ((ready - WAIT_OBJECT_0) < nhandles - 1) {
> for (i = ready - WAIT_OBJECT_0 + 1; i < nhandles; i++) {
> handles[i-1] = handles[i];
> }
> --
> 2.11.0
>
Reviewed-by: Fam Zheng <famz@redhat.com>
next prev parent reply other threads:[~2017-06-29 9:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 23:57 [Qemu-devel] [RFC v1 0/4] Windows runtime improvements Alistair Francis
2017-06-27 23:57 ` [Qemu-devel] [RFC v1 1/4] util/aio-win32: Only select on what we are actually waiting for Alistair Francis
2017-06-29 9:18 ` Fam Zheng
2017-06-29 12:22 ` Paolo Bonzini
2017-06-27 23:57 ` [Qemu-devel] [RFC v1 2/4] util/oslib-win32: Remove invalid check Alistair Francis
2017-06-28 4:12 ` Philippe Mathieu-Daudé
2017-06-29 9:25 ` Fam Zheng
2017-06-29 13:32 ` Paolo Bonzini
2017-06-29 16:37 ` Alistair Francis
2017-06-30 10:37 ` Paolo Bonzini
2017-07-05 15:44 ` Alistair Francis
2017-06-27 23:57 ` [Qemu-devel] [RFC v1 3/4] util/oslib-win32: Fix up if conditional Alistair Francis
2017-06-29 9:34 ` Fam Zheng [this message]
2017-06-29 12:25 ` Paolo Bonzini
2017-06-29 16:31 ` Alistair Francis
2017-06-27 23:57 ` [Qemu-devel] [RFC v1 4/4] util/oslib-win32: Recursivly pass the timeout Alistair Francis
2017-06-29 9:38 ` Fam Zheng
2017-06-29 12:34 ` Paolo Bonzini
2017-06-29 16:33 ` Alistair Francis
2017-06-29 19:47 ` Paolo Bonzini
2017-06-29 21:17 ` Alistair Francis
2017-07-06 23:48 ` [Qemu-devel] [RFC v1 0/4] Windows runtime improvements no-reply
2017-07-07 0:05 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629093409.GE28654@lemon.lan \
--to=famz@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.