From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [kvm-unit-tests PATCH 0/5] Minor fixes while getting rid of code duplication Date: Thu, 29 Jun 2017 13:41:41 +0200 Message-ID: <20170629114141.rd4d5ga755aezvzq@kamzik.brq.redhat.com> References: <20170628200857.1718-1-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, Paolo Bonzini , Laurent Vivier , Thomas Huth , David Hildenbrand To: Radim =?utf-8?B?S3LEjW3DocWZ?= Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60236 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751333AbdF2Llx (ORCPT ); Thu, 29 Jun 2017 07:41:53 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5CA8DC058EB4 for ; Thu, 29 Jun 2017 11:41:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20170628200857.1718-1-rkrcmar@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Jun 28, 2017 at 10:08:52PM +0200, Radim Krčmář wrote: > The series isn't well split, so patches remove the code duplication and > fix bugs at the same time. [3/5] is s390x+powerpc specific, but has > dependency on [4/5], which affects all architectures, just like [1,5/5]. > [2/5] is unrelated, but was simple enough to include. > > > Radim Krčmář (5): > arch/run: simplify copy-paste of the command line > run_tests: add summary to powerpc and s390 > s390+powerpc/run: improve output handling > scripts/arch-run: fix qemu binary search failure path > arch/run: unify accelerator detection > > arm/run | 28 +++------------------ > powerpc/run | 41 ++++-------------------------- > s390x/run | 38 +++------------------------- > scripts/arch-run.bash | 69 +++++++++++++++++++++++++++++++++++++++++++++++---- > scripts/runtime.bash | 2 +- > x86/run | 8 +++--- > 6 files changed, 81 insertions(+), 105 deletions(-) > > -- > 2.13.2 > With Paolo's fixups, the series looks good to me. For the series Reviewed-by: Andrew Jones