From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752802AbdF2M3u (ORCPT ); Thu, 29 Jun 2017 08:29:50 -0400 Received: from guitar.tcltek.co.il ([192.115.133.116]:55841 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752143AbdF2M3m (ORCPT ); Thu, 29 Jun 2017 08:29:42 -0400 Date: Thu, 29 Jun 2017 15:29:39 +0300 From: Baruch Siach To: Steven Rostedt Cc: Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] trace-listen: add missing header Message-ID: <20170629122939.wvt632hf6tnuesf4@tarshish> References: <20170629081956.08115a70@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170629081956.08115a70@gandalf.local.home> User-Agent: NeoMutt/20170306 (1.8.0) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steven, On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote: > On Thu, 29 Jun 2017 14:46:21 +0300 > Baruch Siach wrote: > > > The PATH_MAX macro requires the limits.h header. This fixes build with musl > > libc: > > > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’: > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function) > > snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid"); > > ^~~~~~~~ > > Thanks! I have a few other patches that need to go into trace-cmd. I'll > try to get to that today or tomorrow. There is no rush. By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the same file might bite at some point. Also, MAX_PATH has different values in different files. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -