From mboxrd@z Thu Jan  1 00:00:00 1970
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 4/5] scripts/arch-run: fix qemu binary
 search failure path
Date: Thu, 29 Jun 2017 14:32:46 +0200
Message-ID: <20170629123245.GA10661@potion>
References: <20170628200857.1718-1-rkrcmar@redhat.com>
 <20170628200857.1718-5-rkrcmar@redhat.com>
 <95109d90-f139-e292-aff4-bb60c9569407@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: kvm@vger.kernel.org, Drew Jones <drjones@redhat.com>,
        Laurent Vivier <lvivier@redhat.com>,
        Thomas Huth <thuth@redhat.com>,
        David Hildenbrand <david@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35048 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752740AbdF2Mcy (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 29 Jun 2017 08:32:54 -0400
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id 96C1073B00
        for <kvm@vger.kernel.org>; Thu, 29 Jun 2017 12:32:53 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <95109d90-f139-e292-aff4-bb60c9569407@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

2017-06-28 22:46+0200, Paolo Bonzini:
> On 28/06/2017 22:08, Radim Krčmář wrote:
> > Doing exit from a subshell won't exit the main shell, so arch-run will
> > try to continue without a working QEMU if search_qemu_binary() failed.
> 
> Should it be "exit $?"?

Makes sense.  I was thinking about 'return 1' from search_qemu_binary(),
but never actually went from it.

> Apart from this looks good.  I can do the change.

Please do, thanks.