From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] device property: Move FW type specific functionality to FW specific files
Date: Thu, 29 Jun 2017 13:00:56 +0000 [thread overview]
Message-ID: <20170629130056.xtcf35gxw76ib6gs@mwanda> (raw)
Hello Sakari Ailus,
The patch 3708184afc77: "device property: Move FW type specific
functionality to FW specific files" from Jun 6, 2017, leads to the
following static checker warning:
drivers/base/property.c:256 fwnode_property_present()
warn: assigning (-6) to unsigned variable 'ret'
drivers/base/property.c
247 /**
248 * fwnode_property_present - check if a property of a firmware node is present
249 * @fwnode: Firmware node whose property to check
250 * @propname: Name of the property
251 */
252 bool fwnode_property_present(struct fwnode_handle *fwnode, const char *propname)
253 {
254 bool ret;
255
256 ret = fwnode_call_int_op(fwnode, property_present, propname);
^^^^^^^^^^^^^^^^^^
This macro can return negative error codes, which is treated as true and
I presume true means success.
257 if (ret = false && !IS_ERR_OR_NULL(fwnode) &&
258 !IS_ERR_OR_NULL(fwnode->secondary))
259 ret = fwnode_call_int_op(fwnode->secondary, property_present,
260 propname);
261 return ret;
262 }
263 EXPORT_SYMBOL_GPL(fwnode_property_present);
regards,
dan carpenter
next reply other threads:[~2017-06-29 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 13:00 Dan Carpenter [this message]
2017-06-29 13:04 ` [bug report] device property: Move FW type specific functionality to FW specific files Dan Carpenter
2017-06-29 13:11 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629130056.xtcf35gxw76ib6gs@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.