From: Stefan Hajnoczi <stefanha@gmail.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: pass bdrv_* methods to bs->file by default
Date: Thu, 29 Jun 2017 15:05:21 +0100 [thread overview]
Message-ID: <20170629140521.GC18146@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170627224616.18538-2-el13635@mail.ntua.gr>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Wed, Jun 28, 2017 at 01:46:15AM +0300, Manos Pitsidianakis wrote:
> The following functions fail if bs->drv does not implement them:
>
> bdrv_probe_blocksizes
> bdrv_probe_geometry
> bdrv_truncate
> bdrv_has_zero_init
> bdrv_get_info
> bdrv_media_changed
> bdrv_eject
> bdrv_lock_medium
> bdrv_co_ioctl
>
> Instead, the call should be passed to bs->file if it exists, to allow
> filter drivers to support those methods without implementing them.
>
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
> ---
> block.c | 45 ++++++++++++++++++++++++++++++++++-----------
> block/io.c | 4 ++++
> 2 files changed, 38 insertions(+), 11 deletions(-)
Will you send a block/raw-format.c patch that removes the forwarding
functions that are no longer needed?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2017-06-29 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 22:46 [Qemu-devel] [PATCH 0/2] block: block driver callbacks fixes Manos Pitsidianakis
2017-06-27 22:46 ` [Qemu-devel] [PATCH 1/2] block: pass bdrv_* methods to bs->file by default Manos Pitsidianakis
2017-06-29 14:00 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-06-29 14:05 ` Stefan Hajnoczi [this message]
2017-06-29 16:00 ` Eric Blake
2017-06-27 22:46 ` [Qemu-devel] [PATCH 2/2] block: add default implementations for bdrv_co_get_block_status() Manos Pitsidianakis
2017-06-29 14:04 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629140521.GC18146@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.