All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Aditya Shankar <aditya.shankar@microchip.com>
Cc: linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
	Ganesh.Krishna@microchip.com
Subject: Re: [PATCH v2 5/8] staging: wilc1000: Add new variable for ac queue management
Date: Thu, 29 Jun 2017 16:38:06 +0200	[thread overview]
Message-ID: <20170629143806.GA13007@kroah.com> (raw)
In-Reply-To: <1498477410-19518-6-git-send-email-aditya.shankar@microchip.com>

On Mon, Jun 26, 2017 at 05:13:27PM +0530, Aditya Shankar wrote:
> This patch adds a new variable in the wilc struct to manage
> ac queues.
> 
> Signed-off-by: Aditya Shankar <aditya.shankar@microchip.com>
> ---
>  drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 +
>  1 file changed, 1 insertion(+)

Wait, what is this whole patch series for?  You are adding functions and
variables and not using this functionality at all!  Why are you adding
new functionality to the driver now, and not working to get it out of
staging instead?

I'm going to go drop these patches from the tree now...

thanks,

greg k-h

  reply	other threads:[~2017-06-29 14:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-26 11:43 [PATCH v2 0/8] Enable access category classification on Tx path Aditya Shankar
2017-06-26 11:43 ` [PATCH v2 1/8] staging: wilc1000: Add support for AC classification Aditya Shankar
2017-06-26 11:43 ` [PATCH v2 2/8] staging: wilc1000: Add function to calculate ac queue limit Aditya Shankar
2017-06-26 11:43 ` [PATCH v2 3/8] staging: wilc1000: WMM classification of data Aditya Shankar
2017-06-26 11:43 ` [PATCH v2 4/8] staging: wilc1000: Add function to balance packet count Aditya Shankar
2017-06-26 11:43 ` [PATCH v2 5/8] staging: wilc1000: Add new variable for ac queue management Aditya Shankar
2017-06-29 14:38   ` Greg KH [this message]
2017-06-26 11:43 ` [PATCH v2 6/8] staging: wilc1000: Get packet count from firmware Aditya Shankar
2017-06-26 11:43 ` [PATCH v2 7/8] staging: wilc1000: Change ac based on acm status Aditya Shankar
2017-06-26 11:43 ` [PATCH v2 8/8] staging: wilc1000: Update ACM bit status Aditya Shankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629143806.GA13007@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Ganesh.Krishna@microchip.com \
    --cc=aditya.shankar@microchip.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.