From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH] nvme-rdma: stop keep_alive before nvme_uninit_ctrl
Date: Thu, 29 Jun 2017 16:45:07 +0200 [thread overview]
Message-ID: <20170629144507.GS3808@linux-x5ow.site> (raw)
In-Reply-To: <1498746799-34110-1-git-send-email-dmilburn@redhat.com>
On Thu, Jun 29, 2017@09:33:19AM -0500, David Milburn wrote:
> Its possible for nvme_keep_alive_work() to hit an error
> condition after the nvme_uninit_ctrl() in __nvme_rdma_remove_ctrl().
> This can lead to usage of NULL pointer in "dev_err(ctrl->device..."
> since device has been destroyed by nvme_uninit_ctrl().
>
> This has been seen during continous loop of (discover, connect,
> IO, disconnect).
Why can't we stop the keepalive work in nvme core and get rid of the stopping
in fc.c as well?
--
Johannes Thumshirn Storage
jthumshirn at suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-06-29 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 14:33 [PATCH] nvme-rdma: stop keep_alive before nvme_uninit_ctrl David Milburn
2017-06-29 14:45 ` Johannes Thumshirn [this message]
2017-06-29 15:44 ` David Milburn
2017-06-29 16:24 ` James Smart
2017-07-02 8:08 ` Sagi Grimberg
2017-07-04 9:57 ` Sagi Grimberg
2017-07-05 17:41 ` Christoph Hellwig
2017-07-05 19:04 ` Sagi Grimberg
2017-07-05 19:08 ` Christoph Hellwig
2017-07-05 19:18 ` Sagi Grimberg
2017-07-07 13:27 ` David Milburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629144507.GS3808@linux-x5ow.site \
--to=jthumshirn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.