From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Bill O'Donnell <billodo@redhat.com>
Cc: linux-xfs@vger.kernel.org, sandeen@sandeen.net
Subject: Re: [PATCH] xfs_spaceman: fix potential memory leak by malloc in scan_ag
Date: Thu, 29 Jun 2017 08:59:48 -0700 [thread overview]
Message-ID: <20170629155948.GC5874@birch.djwong.org> (raw)
In-Reply-To: <20170629155256.3607-1-billodo@redhat.com>
On Thu, Jun 29, 2017 at 10:52:56AM -0500, Bill O'Donnell wrote:
> scan_ag mallocs memory that is potentially leaked. Add a free
> to alleviate the potential leak.
>
> Fixes CoverityScan CID#1413772 (RESOURCE_LEAK)
/me feels like the coverity tags he's seen tend to take the format of:
Addresses-Coverity-ID: 1091173
or
Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced")
though to be honest I don't know that there's really a standard.
<shrug> It probably ought to use one of the two more common formats, but
maybe I can just ask Eric to prettyplease fix it on the way in. :)
> Signed-off-by: Bill O'Donnell <billodo@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> spaceman/freesp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/spaceman/freesp.c b/spaceman/freesp.c
> index 22aec821..367c95d1 100644
> --- a/spaceman/freesp.c
> +++ b/spaceman/freesp.c
> @@ -239,7 +239,9 @@ scan_ag(
> printf(_("%10u %10llu %10llu\n"), agno, freeexts,
> freeblks);
> }
> + free(fsmap);
> }
> +
> static void
> aglistadd(
> char *a)
> --
> 2.13.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-29 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 15:52 [PATCH] xfs_spaceman: fix potential memory leak by malloc in scan_ag Bill O'Donnell
2017-06-29 15:59 ` Darrick J. Wong [this message]
2017-06-29 16:28 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629155948.GC5874@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=billodo@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.